Header discipline in base #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtsam/base/Matrix.cpp
Outdated
| @@ -33,6 +34,7 @@ | |||
| #include <fstream> | |||
| #include <limits> | |||
| #include <iostream> | |||
| #include <iostream> | |||
There was a problem hiding this comment.
If you reviewed everything and you trust me to fix the above, approve??
There was a problem hiding this comment.
There is this cool tool called include-what-you-use which we should probably leverage.
| #include <iostream> | ||
| #include <cstdlib> | ||
| #include <fstream> | ||
| #include <sstream> |
There was a problem hiding this comment.
Pretty sure fstream includes iostream for us, but I like being explicit so yay!
varunagrawal
approved these changes
Feb 17, 2022
Yeah, tried that at one point. Its not so great for large repos with boost and Eigen. Maybe we should try it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to cut down on compile times, so