Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes #1187

Merged
merged 4 commits into from
May 8, 2022
Merged

Some fixes #1187

merged 4 commits into from
May 8, 2022

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented May 5, 2022 •
edited
Loading

  1. Based on my meeting with @dellaert, this PR removes the key formatting when writing the vertices in the dot file. This prevents syntax errors when using keys from GTDynamics for example.
  2. I was looking into the PriorFactor as part of the legged robot state estimator and found the tests lacking. Added more tests so I can be more confident in what is happening.

@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label May 5, 2022
@varunagrawal varunagrawal requested a review from dellaert May 5, 2022 15:27
@varunagrawal varunagrawal self-assigned this May 5, 2022
dellaert
dellaert approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved so you can merge but CI seems to fail.

@varunagrawal
Copy link
Collaborator Author

Oof my bad. Updated the unit tests to capture the correct thing.

@varunagrawal varunagrawal merged commit fb1da00 into develop May 8, 2022
@varunagrawal varunagrawal deleted the dot-printer branch May 8, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert