-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update geometry.i : wrap multiplication of Rot3 and Unit3 #1302
Conversation
@akshay-krishnan please add some unit tests and I will happily approve this. :) |
@akshay-krishnan any updates on this? We're looking to release a new version, and if you can finish up the unit tests, let's land this so it can be included in the 4.2 release. |
Thanks for the reminder Varun, I'll update it today |
@varunagrawal I could not wrap the * operator, got the error "no supported * operator between Rot3 and Unit3", although I added the method in geometry.i (see my first commit). So I had to remove that, rotate() and unrotate() are fine, and apparently * operator is not wrapped for Point3 either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Huh that's strange. I can take a look at it later maybe? Super swamped. |
No description provided.