Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code deprecated in 4.2 #1399

Merged
merged 5 commits into from
Jan 21, 2023
Merged

Remove code deprecated in 4.2 #1399

merged 5 commits into from
Jan 21, 2023

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Jan 21, 2023 •
edited
Loading

This PR

  • Removes code deprecated in 4.2
  • Renames flags
  • cleans up a few cmake-related issues from Kartik's PR.

Also fixes issue #1400

@dellaert dellaert added the quick-review Quick and easy PR to review label Jan 21, 2023
@dellaert dellaert self-assigned this Jan 21, 2023
@dellaert dellaert mentioned this pull request Jan 21, 2023
Closed
@dellaert dellaert requested a review from gchenfc January 21, 2023 21:10
gchenfc
gchenfc approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@gchenfc gchenfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

timing/timeLago.cpp Show resolved Hide resolved
@gchenfc gchenfc merged commit 6787bbe into develop Jan 21, 2023
@gchenfc gchenfc deleted the feature/remove_deprecated_code branch January 21, 2023 22:05
varunagrawal
varunagrawal approved these changes Jan 21, 2023
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

@gchenfc gchenfc gchenfc approved these changes

@jlblancoc jlblancoc Awaiting requested review from jlblancoc

Assignees

@dellaert dellaert

Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dellaert @varunagrawal @gchenfc