Discrete Elimination Refactor #1919
Draft
+172
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 306a3ba.
varunagrawal
commented
Dec 8, 2024
gtsam/discrete/DiscreteFactor.h
Outdated
| virtual DecisionTreeFactor operator*(const DecisionTreeFactor&) const = 0; | ||
| /// Multiply in a DiscreteFactor and return the result as | ||
| /// DiscreteFactor | ||
| virtual DiscreteFactor::shared_ptr operator*( |
There was a problem hiding this comment.
Should this be a DiscreteFactor::shared_ptr or a DiscreteFactor& (aka a reference?)
|
Maybe only "push" if you want me to look again? Every push is a CI |
Yup. I am going to table this PR for the time being since a full refactor may not be needed. I did manage to pull a lot of cool fixes and updates from this PR and merge them into the develop branch so that's a win. For longer term, having a scheme where all operations are polymorphic in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor discrete elimination so it is agnostic to the underlying derived type of the
DiscreteFactor.