Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoiseModelFactorN - fixed-number of variables >6 #947

Merged
merged 45 commits into from
Dec 23, 2022
Merged

NoiseModelFactorN - fixed-number of variables >6 #947

merged 45 commits into from
Dec 23, 2022

Commits on Dec 1, 2021

  1. NoiseModelFactorN - fixed-number of variables >6

    @gchenfc
    gchenfc committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    81f1d93 View commit details
    Browse the repository at this point in the history

  2. c++11 doesn't support std::size so use obj.size() instead

    @gchenfc
    gchenfc committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    e037fa1 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. alternate make_index_sequence impl if no boost::mp11

    @gchenfc
    gchenfc committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    d9c8ce2 View commit details
    Browse the repository at this point in the history

  2. optional jacobian overloads backwards compatibility

    @gchenfc
    gchenfc committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    2aecaf3 View commit details
    Browse the repository at this point in the history

  3. backward compatibility unit tests for NoiseModelFactor4

    @gchenfc
    gchenfc committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    8fe7e48 View commit details
    Browse the repository at this point in the history

  4. NoiseModelFactor4 implemented as derived class of NoiseModelFactorN

    @gchenfc
    gchenfc committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    bee4eee View commit details
    Browse the repository at this point in the history

  5. converted all NoiseModelFactorX to inherit from NoiseModelFactorN

    @gchenfc
    gchenfc committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    ed07edb View commit details
    Browse the repository at this point in the history

  6. documentation

    @gchenfc
    gchenfc committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    ea7d769 View commit details
    Browse the repository at this point in the history

  7. avoid inheritance by conditionally defining backwards compatibility t… 

    …ypes/funcs in NoiseModelFactorN
    @gchenfc
    gchenfc committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    ba3cc85 View commit details
    Browse the repository at this point in the history

  8. switch template bool specialization order

    @gchenfc
    gchenfc committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    ddcca4c View commit details
    Browse the repository at this point in the history

  9. can't get "using NoiseModelFactorX = NoiseModelFactorN" to work

    @gchenfc
    gchenfc committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    280acde View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. alternate option for typedef-ing X1, X2, ...

    @gchenfc
    gchenfc committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    89b4340 View commit details
    Browse the repository at this point in the history

  2. revert typedef X1, X2, ... to old version, and clean up a little

    @gchenfc
    gchenfc committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    5004c47 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. switch using NoiseModelFactorX = ... to #define .... 

    Reasoning is given as comments.
    @gchenfc
    gchenfc committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    018213e View commit details
    Browse the repository at this point in the history

  2. fix Windows CI issue: VALUE happens to have the same name in PriorFactor

    @gchenfc
    gchenfc committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    84e873e View commit details
    Browse the repository at this point in the history

  3. review comments

    @gchenfc
    gchenfc committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    40e585b View commit details
    Browse the repository at this point in the history

  4. update doxygen (review comment)

    @gchenfc
    gchenfc committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    11fd861 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2022

  1. Merge branch 'develop' into feature/NoiseModelFactorN

    @gchenfc
    gchenfc committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    3addc8d View commit details
    Browse the repository at this point in the history

  2. create backwards compatibility unit test for NoiseModelFactor1

    @gchenfc
    gchenfc committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    c9dbb6e View commit details
    Browse the repository at this point in the history

  3. revert some template stuff with inheritance for readability 

    NoiseModelFactor123456 are now minimal classes that inherit from NoiseModelFactorN
    @gchenfc
    gchenfc committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    bb33be5 View commit details
    Browse the repository at this point in the history

  4. move boost::index_sequence stuff to utilities file

    @gchenfc
    gchenfc committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    82e0d20 View commit details
    Browse the repository at this point in the history

  5. fix namespace collision with symbol_shorthand::X in unit test

    @gchenfc
    gchenfc committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    d62033a View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Revert "create backwards compatibility unit test for NoiseModelFactor1" 

    This reverts commit c9dbb6e.
    @gchenfc
    gchenfc committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    a2fb0e4 View commit details
    Browse the repository at this point in the history

  2. Serialize test strings generated with Boost 1.65

    @gchenfc
    gchenfc committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    1a427cd View commit details
    Browse the repository at this point in the history

  3. fix test xml file path

    @gchenfc
    gchenfc committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    6653d66 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. fix expected serialization string

    @gchenfc
    gchenfc committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    782a894 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/NoiseModelFactorN 

    #1102 correctly removed "GTSAM_EXPORT" from NoiseModelFactorX
    @gchenfc
    gchenfc committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    8ae8c7a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. serialization debugging (from stash)

    @gchenfc
    gchenfc committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    71767a4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/NoiseModelFactorN_test

    @gchenfc
    gchenfc committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    2ea97fb View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. update serialized string

    @gchenfc
    gchenfc committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    00cf13b View commit details
    Browse the repository at this point in the history

  2. bugfix on serialization

    @gchenfc
    gchenfc committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    ea6e32d View commit details
    Browse the repository at this point in the history

  3. remove debug statements

    @gchenfc
    gchenfc committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    8327685 View commit details
    Browse the repository at this point in the history

  4. turn off backwards compatibility test with quaternions or TBB since s… 

    …erialization structure is different
    @gchenfc
    gchenfc committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    fa196aa View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Merge branch 'develop' into feature/NoiseModelFactorN (for CI)

    @gchenfc
    gchenfc committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    1127276 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. address review comments

    @gchenfc
    gchenfc committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    322e555 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. fix boost 1.65 patch bug

    @gchenfc
    gchenfc committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    94865c4 View commit details
    Browse the repository at this point in the history

  2. Revert "fix namespace collision with symbol_shorthand::X in unit test" 

    This reverts commit d62033a.
    @gchenfc
    gchenfc committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    63950b9 View commit details
    Browse the repository at this point in the history

  3. Change X<N> to ValueType<N> and VALUES -> ValueTypes

    @gchenfc
    gchenfc committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    0ebc6e8 View commit details
    Browse the repository at this point in the history

  4. address review comments

    @gchenfc
    gchenfc committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    b24511f View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Check type of CONTAINER constructor tparam 

    This is a byproduct of the overload resolution problem when N=1, then it can be hard to differentiate between:
NoiseModelFactorN(noise, key)
NoiseModelFactorN(noise, {key})
    @gchenfc
    gchenfc committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    e8ddbbe View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. make SFINAE templates more readable

    @gchenfc
    gchenfc committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    040eb63 View commit details
    Browse the repository at this point in the history

  2. better docstrings w/ usage examples

    @gchenfc
    gchenfc committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    d16d263 View commit details
    Browse the repository at this point in the history

  3. Change backwards-compatibility defs to utilize new style

    @gchenfc
    gchenfc committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    4b93970 View commit details
    Browse the repository at this point in the history

  4. update and fix unit tests

    @gchenfc
    gchenfc committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    19215af View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into feature/NoiseModelFactorN_replaceDeprecated

    @gchenfc
    gchenfc committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    2a7efc7 View commit details
    Browse the repository at this point in the history