Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Browser crash when trying to enable staging server #11114

Closed
srirambv opened this issue Aug 6, 2020 · 4 comments
Closed

[Android] Browser crash when trying to enable staging server #11114

srirambv opened this issue Aug 6, 2020 · 4 comments
Labels
ARM Android ARM related issues bug crash feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release/blocking release-notes/exclude
Milestone
1.12.x - Release #1

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 6, 2020

Description

Browser crash when trying to enable staging server

Steps to reproduce

  1. Clean install 1.12.108
  2. Enable QA preferences and turn on staging rewards
  3. Try again browser crashes

Actual result

Browser crashes when trying to enable staging rewards

Expected result

Should not crash and enable staging rewards

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Maybe

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.12.108

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information
@srirambv srirambv added this to the Android 1.12.x - Release milestone Aug 6, 2020
@srirambv srirambv mentioned this issue Aug 7, 2020
Closed
@kjozwiak
Copy link
Member

@srirambv should this be closed now that we've landed both brave/brave-core#6221 and brave/brave-core#6267?

@srirambv
Copy link
Contributor Author

No this is still happening on 1.12.111 build even though brave/brave-core#6221 (1.12.x uplift brave/brave-core#6354) and brave/brave-core#6267 (1.12.x uplift brave/brave-core#6356 both been uplifted.

@kjozwiak
Copy link
Member

kjozwiak commented Aug 11, 2020 •
edited
Loading

No this is still happening on 1.12.111 build even though brave/brave-core#6221 (1.12.x uplift brave/brave-core#6354) and brave/brave-core#6267 (1.12.x uplift brave/brave-core#6356 both been uplifted.

Thanks for the double check 👍 Reproducing on my S10+ running 1.12.111 CR: 84.0.4147.111. @tmancey believe you mentioned this might be related to ads code? Is there anything that we need to get uplifted?

@srirambv
Copy link
Contributor Author

This is fixed on 1.12.112 which has the hash commit ee9ae87c6510eb331f2d23b617ea7aa31ee815ef.

Verification passed on OnePlus 6T with Android 10 running 1.12.112 x64 build

  • Verified browser doesn't crash when trying to switch to staging server

Verification passed on Samsung Tab A with Android 10 running 1.12.112 x64 build

  • Verified browser doesn't crash when trying to switch to staging server

@LaurenWags LaurenWags added the ARM Android ARM related issues label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ARM Android ARM related issues bug crash feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Milestone
1.12.x - Release #1
Development

No branches or pull requests
3 participants
@kjozwiak @srirambv @LaurenWags