Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set staging server preference after state is reset, not before #6221

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jul 27, 2020

Resolves brave/brave-browser#10929

Needed due to change in brave/brave-browser#10064.

Submitter Checklist:

Test Plan:

  • Enable Developer Options
  • In QA settings, switch to Rewards staging server
  • After restart, create wallet
  • Ensure (via logs) that wallet is created on staging server

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@emerick emerick self-assigned this Jul 27, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 27, 2020
@emerick emerick added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Unable to create wallet on staging
3 participants