Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set staging server preference after state is reset, not before (uplift to 1.12.x) #6354

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Aug 6, 2020

Uplift of #6221

@emerick emerick added this to the 1.12.x - Release milestone Aug 6, 2020
@emerick emerick requested a review from a team August 6, 2020 15:32
@emerick emerick self-assigned this Aug 6, 2020
@emerick emerick added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Aug 6, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 6, 2020

Looks like the Skip labels were added too late and all the plaforms ran either way. Going to mention the failures that happened below but won't be restarting as it's Android specific and that passed without any failures/issues.

Other failures (not blocking uplift nor restarting as per the above):

test-browser failed on macOS as per the following https://ci.brave.com/job/pr-brave-browser-rewards-fix-staging-switch-android_1.12.xx/1/execution/node/658/log/.

13:09:45  FAILED: alwaysrununittests/fix_test_install_name_brave 
13:09:45  python ../../build/gn_run_binary.py /usr/bin/install_name_tool -change @loader_path/../../Libraries/libadblock.dylib @executable_path/gen/adblock/out/x86_64-apple-darwin/release/libadblock.dylib -change @loader_path/../../Libraries/libchallenge_bypass_ristretto.dylib @executable_path/gen/challenge_bypass_ristretto/out/x86_64-apple-darwin/release/libchallenge_bypass_ristretto.dylib -change @loader_path/../../Libraries/libspeedreader_ffi.dylib @executable_path/gen/speedreader/out/x86_64-apple-darwin/release/libspeedreader_ffi.dylib brave_unit_tests
13:09:45  error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: brave_unit_tests (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)
13:09:45  /usr/bin/install_name_tool failed with exit code 1

Looks like Win x64 dropped the spot instance/agent removed as per https://ci.brave.com/job/pr-brave-browser-rewards-fix-staging-switch-android_1.12.xx/1/execution/node/221/log/.

12:16:12  Cannot contact i-04efdb04dd9d31b12: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@7b426108:i-04efdb04dd9d31b12": Remote call on i-04efdb04dd9d31b12 failed. The channel is closing down or has closed down
12:21:12  Could not connect to i-04efdb04dd9d31b12 to send interrupt signal to process

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift approved into 1.12.x after deliberating with @brave/uplift-approvers. QA has verified that enabling rewards staging is working on Nightly as per #6267 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants