Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set staging server preference in reset callback (uplift to 1.12.x) #6356

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Aug 6, 2020

Uplift of #6267

@emerick emerick added this to the 1.12.x - Release milestone Aug 6, 2020
@emerick emerick requested a review from a team August 6, 2020 15:43
@emerick emerick self-assigned this Aug 6, 2020
@emerick emerick added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Aug 6, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 6, 2020

Looks like the Skip labels were added too late and all the plaforms ran either way. Going to mention the failures that happened below but won't be restarting as it's Android specific and that passed without any failures/issues.

Other failures (not blocking uplift nor restarting as per the above):

test-browser failed on Linux due to RewardsBrowserTest.ShowACPercentInThePanel failing as per https://ci.brave.com/job/pr-brave-browser-rewards-fix-staging-switch-android-2_1.12.xx/1/execution/node/542/log/.

12:47:23  Stack trace:
12:47:23  #0 0x55ce6a128e69 (/home/ubuntu/jenkins/workspace/pr-brave-browser-rewards-fix-staging-switch-android-2_1.12.xx/src/out/Release/brave_browser_tests+0x5c80e68)
12:47:23  
12:47:23  [615/617] RewardsBrowserTest.ShowACPercentInThePanel (CRASHED)
12:47:36  1 test crashed:
12:47:36      RewardsBrowserTest.ShowACPercentInThePanel (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:309)

Looks like Win x64 dropped the spot instance/agent removed as per https://ci.brave.com/job/pr-brave-browser-rewards-fix-staging-switch-android-2_1.12.xx/1/execution/node/144/log/.

12:16:11  Cannot contact i-069b2c55a26d28b9b: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel
12:21:12  Could not connect to i-069b2c55a26d28b9b to send interrupt signal to process

@kjozwiak
Copy link
Member

kjozwiak commented Aug 6, 2020

@emerick mind fixing the above conflict? Assuming it happened when we merged #6354 (review).

@emerick emerick force-pushed the rewards-fix-staging-switch-android-2_1.12.xx branch from de6e7f8 to 1649dd3 Compare August 6, 2020 21:08
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA has also verified that rewards staging is working on Nightly as per #6267 (comment).

@kjozwiak kjozwiak merged commit 3f728ac into 1.12.x Aug 7, 2020
@kjozwiak kjozwiak deleted the rewards-fix-staging-switch-android-2_1.12.xx branch August 7, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants