Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing text from dark to light grey via ads/ac selection panel #13911

Closed
kjozwiak opened this issue Feb 2, 2021 · 2 comments · Fixed by brave/brave-core#7834
Closed

changing text from dark to light grey via ads/ac selection panel #13911

kjozwiak opened this issue Feb 2, 2021 · 2 comments · Fixed by brave/brave-core#7834

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

Description

We fixed the issue re: the text appearing as a hyperlink via #13800. However, rather than using the light grey text that was mentioned via #13800 (comment), we're using basic/black text which blends into everything else on that particular onboarding panel.

Steps to reproduce

  1. launch 1.21.39 CR: 88.0.4324.96
  2. run through the rewards onboarding and navigate to the panel where you pick number of ads/ac amount.

Actual result

Screenshot_20210202-150839_Brave - Nightly

Expected result

Should look as per #13800 (comment):

Screen Shot 2021-01-27 at 10 15 19 AM

Issue reproduces how often

100% reproducible using the above STR.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Will be introduced into 1.19.x via Update text colour on rewards onboarding brave-core#7764
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung S10+
  • Android version: Android 11

Brave version

  • 1.21.39 CR: 88.0.4324.96 - Reproduced

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @codybanxs @deeppandya @srirambv

@deeppandya
Copy link

Screenshot_20210204-170834

@srirambv
Copy link
Contributor

srirambv commented Apr 7, 2021

Verification passed on the following devices running 1.23.63 x64 beta build

OnePlus 6T (Android 10) Samsung Tab A (Android 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants