-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update text colour on rewards onboarding #7764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Verification PASSED on
After speaking with @codybanxs & @deeppandya, the "light grey text" that's exampled via brave/brave-browser#13800 (comment) will be addressed in the UI revamp in |
@deeppandya @codybanxs I wouldn't consider this a blocker either way but |
@kjozwiak thank you mentioning it. I will definitely take a look and update it in the follow up issue. |
Sounds good @deeppandya 👍 Created brave/brave-browser#13909 re: alignment issues. |
Resolves brave/brave-browser#13800
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan: