Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text colour on rewards onboarding #7764

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Update text colour on rewards onboarding #7764

merged 1 commit into from
Feb 2, 2021

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#13800

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 1, 2021
@deeppandya deeppandya added this to the 1.21.x - Nightly milestone Feb 1, 2021
@deeppandya deeppandya self-assigned this Feb 1, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

Verification PASSED on Samsung S10+ running Android 10 using the following build:

1.21.39 CR: 88.0.4324.96
Example Text Link Fixed Example Text Link Fixed
Screenshot_20210202-150839_Brave - Nightly Screenshot_20210202-134043_Brave - Nightly
Alignment Improved #1 Alignment Improved #2
Screenshot_20210202-134027_Brave - Nightly Screenshot_20210202-133743_Brave - Nightly

After speaking with @codybanxs & @deeppandya, the "light grey text" that's exampled via brave/brave-browser#13800 (comment) will be addressed in the UI revamp in 1.21.x.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

@deeppandya @codybanxs I wouldn't consider this a blocker either way but Alignment Improved #2 still looks a but unaligned at the bottom where the blue text and the grey bottom text have a small offset. We can create a new issue for the above as brave/brave-browser#13800 was technically about fixing the text so it doesn't look like a hyperlink.

@deeppandya
Copy link
Contributor Author

@deeppandya @codybanxs I wouldn't consider this a blocker either way but Alignment Improved #2 still looks a but unaligned at the bottom where the blue text and the grey bottom text have a small offset. We can create a new issue for the above as brave/brave-browser#13800 was technically about fixing the text so it doesn't look like a hyperlink.

@kjozwiak thank you mentioning it. I will definitely take a look and update it in the follow up issue.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

Sounds good @deeppandya 👍 Created brave/brave-browser#13909 re: alignment issues.

@deeppandya deeppandya changed the title Fix #13800 Update text colour on rewards onboarding Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update text colour on onboarding to not make it look like a hyperlink
3 participants