Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text colour on rewards onboarding (uplift to 1.19.x) #7775

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Update text colour on rewards onboarding (uplift to 1.19.x) #7775

merged 1 commit into from
Feb 2, 2021

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Feb 2, 2021 •
edited by kjozwiak
Loading

Uplift of #7764
Resolves brave/brave-browser#13800

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 2, 2021
@deeppandya deeppandya added this to the 1.19.x - Release #3 milestone Feb 2, 2021
@deeppandya deeppandya requested a review from a team February 2, 2021 04:00
@deeppandya deeppandya self-assigned this Feb 2, 2021
kjozwiak
kjozwiak approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.19.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7764 (comment).

@kjozwiak kjozwiak merged commit e9a2177 into 1.19.x Feb 2, 2021
@kjozwiak kjozwiak deleted the pr7764_issue_13800_1.19.x branch February 2, 2021 20:59
@deeppandya deeppandya changed the title Fix #13800 (uplift to 1.19.x) Update text colour on rewards onboarding (uplift to 1.19.x) Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.19.x - Release #3
Development

Successfully merging this pull request may close these issues.
2 participants
@deeppandya @kjozwiak