-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update text colour on onboarding to not make it look like a hyperlink #13800
Comments
@codybanxs can you add cheanges for https://bravesoftware.slack.com/archives/C0816QH3R/p1611576288027100 and https://bravesoftware.slack.com/archives/C0816QH3R/p1611572924020300 as well ? |
Adding screens for context for QA/others looking at this issue. This should also fix a few translation alignment issues as well. Screens @srirambv 👍
|
I spoke with @deeppandya and this color change will be reflected in 1.21 as it was missed for 1.20. This is not a blocking issue so we can keep going and I will bring this up again when 1.21 arrives. cc: @kjozwiak |
Created #13909 for the misalignment and #13911 to change the text from black to light grey as per #13800 (comment). |
Verification passed on the following devices running 1.19.90 x64 build
|
Currently happening in |
Description
Update text colour on onboarding to not make it look like a hyperlink
Steps to reproduce
You can change this later.
message looks like an hyperlink but isn'tActual result
Expected result
Just text shouldn't look like a hyperlink
Issue reproduces how often
Easy
Version/Channel Information:
Device details
Brave version
1.20.89
Website problems only
Additional information
The text was updated successfully, but these errors were encountered: