Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text colour on onboarding to not make it look like a hyperlink #13800

Closed
srirambv opened this issue Jan 27, 2021 · 7 comments · Fixed by brave/brave-core#7764
Closed

Comments

@srirambv
Copy link
Contributor

Description

Update text colour on onboarding to not make it look like a hyperlink

Steps to reproduce

  1. Go through RE onboarding by opting in
  2. Go to the slide that allows to set monthly budget
  3. You can change this later. message looks like an hyperlink but isn't

Actual result

image

Expected result

Just text shouldn't look like a hyperlink

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.20.89

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv srirambv added feature/rewards QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Jan 27, 2021
@ghost
Copy link

ghost commented Jan 27, 2021

Here is the updated string color for the text!
Screen Shot 2021-01-27 at 10 15 19 AM

@deeppandya
Copy link

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

@codybanxs can you add cheanges for https://bravesoftware.slack.com/archives/C0816QH3R/p1611576288027100 and https://bravesoftware.slack.com/archives/C0816QH3R/p1611572924020300 as well ?

Adding screens for context for QA/others looking at this issue. This should also fix a few translation alignment issues as well. Screens @srirambv 👍

Example Example
Screenshot_20210125-115947 Screenshot_20210125-120018

@ghost
Copy link

ghost commented Feb 2, 2021

I spoke with @deeppandya and this color change will be reflected in 1.21 as it was missed for 1.20. This is not a blocking issue so we can keep going and I will bring this up again when 1.21 arrives. cc: @kjozwiak

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

Created #13909 for the misalignment and #13911 to change the text from black to light grey as per #13800 (comment).

@srirambv
Copy link
Contributor Author

srirambv commented Feb 3, 2021

Verification passed on the following devices running 1.19.90 x64 build

OnePlus 6T (Android 10) Samsung Tab A (Android 10)

@kjozwiak
Copy link
Member

kjozwiak commented Feb 4, 2021

Currently happening in 1.19.88 CR: 88.0.4324.96 so adding release-notes/include as the issue was already user facing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants