Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Startpage icon too large size during onboarding #15611

Closed
wchen342 opened this issue May 4, 2021 · 1 comment · Fixed by brave/brave-core#8701
Closed

Startpage icon too large size during onboarding #15611

wchen342 opened this issue May 4, 2021 · 1 comment · Fixed by brave/brave-core#8701
Assignees
@deeppandya
Labels
misc/icons onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.25.x - Release

Comments

@wchen342
Copy link

wchen342 commented May 4, 2021

The new startpage icon is larger than others, see below:
screen

Only happening on Nightly, likely caused by brave/brave-core/pull/8656.
@wchen342 wchen342 added the OS/Android Fixes related to Android browser functionality label May 4, 2021
@srirambv srirambv added misc/icons onboarding Front-end related to helping a new user learn about features within the browser. QA/Yes release-notes/exclude labels May 4, 2021
@deeppandya deeppandya self-assigned this May 4, 2021
@deeppandya deeppandya mentioned this issue May 4, 2021
Merged
24 tasks
@bsclifton bsclifton added this to the 1.26.x - Nightly milestone May 4, 2021
@kjozwiak kjozwiak mentioned this issue May 12, 2021
Merged
7 tasks
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.25.60 x64 Beta Build

  • Verified icon is shown properly
Android.ARM.Stargpage.mp4

Verification passed on Samsung Tab A with Android 10 running 1.25.60 x64 Beta Build

  • Verified icon is shown properly
Android.Tab.Startpage.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
misc/icons onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

Update icons for Startpage SE brave/brave-core
5 participants
@kjozwiak @bsclifton @deeppandya @wchen342 @srirambv