Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons for Startpage SE #8701

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#15611

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 4, 2021
@deeppandya deeppandya added this to the 1.26.x - Nightly milestone May 4, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@wchen342 wchen342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@deeppandya deeppandya merged commit efb29cc into master May 4, 2021
@deeppandya deeppandya deleted the Update_start_page_se_icons branch May 4, 2021 18:32
@bsclifton bsclifton mentioned this pull request May 4, 2021
24 tasks
@bsclifton
Copy link
Member

Uplift to 1.25 needed because the icons were changed there. Will look at making uplift now 😄

@deeppandya
Copy link
Contributor Author

@bsclifton i am on it. i tried to use CI but it failed for some reason. so creating uplift manually.

@bsclifton
Copy link
Member

Ran into that same failure too it seems 😂 Thanks, @deeppandya! 😄

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.26.11 x64 Nightly build

  • Verified StartPage icon is similar to the other ones during onboarding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startpage icon too large size during onboarding
5 participants