Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update startpage icons (Uplift to 1.25.x) #8763

Merged
merged 1 commit into from
May 12, 2021
Merged

update startpage icons (Uplift to 1.25.x) #8763

merged 1 commit into from
May 12, 2021

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented May 10, 2021 •
edited by kjozwiak
Loading

Uplift of #8701
Resolves brave/brave-browser#15611

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 10, 2021
@deeppandya deeppandya added this to the 1.25.x - Beta milestone May 10, 2021
@deeppandya deeppandya requested a review from a team May 10, 2021 17:49
@deeppandya deeppandya self-assigned this May 10, 2021
@deeppandya deeppandya changed the title update startpage icons update startpage icons (Uplift to 1.25.x) May 10, 2021
kjozwiak
kjozwiak approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.25.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8656 (comment) & #8701 (comment).

@kjozwiak kjozwiak merged commit fd4b0e8 into 1.25.x May 12, 2021
@kjozwiak kjozwiak deleted the Update_start_page_se_icons_1.25.x branch May 12, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@deeppandya @kjozwiak