Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "manual refresh" button to fetch a new version of the verified publishers list, on demand #3339

Closed
Miyayes opened this issue Feb 13, 2019 · 11 comments · Fixed by brave/brave-core#2121

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 13, 2019

Description and motivation for feature request

At the moment, the browser updates the verified publishers_list file only once per 48 hours. (In an upcoming release, this will be reduced to 24h). However, this fetching process has been error-prone and can be interrupted by regular use of the browser. There have been a high number of reports of the publishers_list becoming stale and failing to update on schedule.

Furthermore, given the new flow for tips to unverified creators, time-to-browser-side-verification-status has become especially important to publishers, as verification status now has material—i.e., financial—ramifications for publishers. (E.g., Tips may be delayed or not sent due to browser-side unverified status.) Providing more ways to stay up to date with the verified publishers list will help, in addition to being satisfying for publishers who just verified their channels and would like to be reassured of their verification status browser-side.

The current workaround solution requires the user to manually rename, move or delete the publishers_list file from their brave-browser/default folder. However, this is beyond the ken of many mainstream users, and like all "workarounds", is fundamentally unsustainable. Overall, stale publishers_list issues have imposed a substantial tax on the support teams.

Solution

Add a button in the browser that forces the browser to download a new version of the publishers_list from the appropriate API endpoint (e.g., https://publishers.basicattentiontoken.org/api/v1/public/channels). Users can manually click this button to refresh their verification list.

Community support for feature

This has been brought up internally, and has also received support in the community. See, for example, https://community.brave.com/t/add-setting-to-refresh-list-of-verified-sites/44924.

@Miyayes
Copy link
Collaborator Author

Miyayes commented Feb 15, 2019

Another +1 from community: https://community.brave.com/t/verified-channel-not-showing-as-verified-in-browser/44763/3?u=chriscat

Is there someplace in the browser where we can manually kick off the publisher update?

Would have been nice to see a warning in the publisher profile indicating to the user that it could take up to 48 hours.

@Miyayes
Copy link
Collaborator Author

Miyayes commented Feb 22, 2019

+1 from Reddit: https://www.reddit.com/r/BATProject/comments/atjkxg/delay_period_after_verification_one_suggestion/

add an option "Update list of creators" in the Browser (probably in the settings, not in the main GUI). So people can "update" their list when they want, without waiting 48h

@Miyayes
Copy link
Collaborator Author

Miyayes commented Feb 28, 2019

Note for triage: 65% of my day is spent handling cases related to this issue. This will only increase as more publishers verify (charts on batgrowth.com show an accelerating curve). Even with the 24h update now live, downloading of the publisher_list by the browser remains very unreliable and fickle (i.e., browsers do not seem to be respecting the 24h refresh time).

Again, this has material consequences for publishers because of the new client-side tipping flow for unverified channels.

If there were a button to simply refresh the publisher_list, this would eliminate ~65% of support queries. @rebron

@bsclifton
Copy link
Member

cc: @jsecretan for prioritization

@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed suggestion labels Mar 1, 2019
@NejcZdovc
Copy link
Contributor

currently blocked on new settings dialog for rewards

@mandar-brave
Copy link

@jenn-rhim can we get this prioritized for @NejcZdovc from a design perspective.
I think you have an idea where to place the setting to get a manual refresh done for the Publisher list.

@jenn-rhim
Copy link

image

@bradleyrichter
Copy link

image

@NejcZdovc
Copy link
Contributor

@bradleyrichter @jenn-rhim should we should only this when publisher is unverified?

@bradleyrichter
Copy link

bradleyrichter commented Mar 25, 2019

@NejcZdovc non-verified only. (not yet verified)

jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 12, 2019
Fix spacing

Address PR comments

Moving callback to api

Updates mounting state

lint fixes

Updating publisher persist

Addresses PR comments

lint

Updated brave-ui hash

Fixing merge

fixing merge

fixing merge

fixing merge

Moving function

fixing merge

fixing merge

update brave-ui

Address PR comments

unbumping

Update type name
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 15, 2019
Fix spacing

Address PR comments

Moving callback to api

Updates mounting state

lint fixes

Updating publisher persist

Addresses PR comments

lint

Updated brave-ui hash

Fixing merge

fixing merge

fixing merge

fixing merge

Moving function

fixing merge

fixing merge

update brave-ui

Address PR comments

unbumping

Update type name
@NejcZdovc NejcZdovc added this to the 0.65.x - Nightly milestone Apr 15, 2019
@LaurenWags
Copy link
Member

LaurenWags commented May 8, 2019

Verified passed with

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.