-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Ad Rewards settings panel #4008
Comments
I don't see 0 but I do see a lot less then I am supposed to have. Every time I open the program the number drops so it's not only a problem with the date. https://streamable.com/ekvlv |
@JoelMon could you please record a longer video showing the balance continuing to drop so I can investigate further as I am unable to reproduce the issue, thanks |
For the past few releases I've noticed that the balance has not dropped. I'm using Version 0.64.40 Chromium: 74.0.3729.61 (Official Build) dev (64-bit) and I haven't noticed any drop. I'll continue to keep my eyes on it and let you know if I see it dropping again, hopefully this time around I'll record it at a better quality. 👋 |
So, discussing with @mandar-brave and @davidtemkin, we want to:
|
Because cashed in and un-cashed in confirmations are not currently connected, and because we want to avoid drastic changes to the schema, @tmancey has suggested a way where we know to determine what was not yet cashed in: |
Verified passed with
Verification passed on
Verification PASSED on
Verification passed on
|
References:
Currently the uncashed tokens are sent to the server, against a wallet ID, every week.
On the 5th of each month, Brave Rewards resets the estimated earnings counter to zero.
Issue:
Because the uncashed tokens are not in sync (weekly redemption vs. one time monthly payment), when the counter resets to zero, the user may perceive that they lost earned tokens.
Fix:
When the clock gets to the 5th of the month, the user should see the tokens that were not redeemed yet.
Prioritizing it as a P1 since it feels like earned BAT was lost.
@jsecretan @evq @NejcZdovc @tmancey
The text was updated successfully, but these errors were encountered: