Fix the Ad Rewards settings panel 0.65.x #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/4008-0.65.x
branch
from
115d3d0
to
375bb0a
Compare
tmancey
force-pushed
the
issues/4008-0.65.x
branch
2 times, most recently
from
d684410
to
c87fb1d
Compare
bsclifton
requested changes
May 6, 2019
There was a problem hiding this comment.
Getting a few errors here:
- unit tests
2 tests failed:
MediaYouTubeTest.GetChannelUrl (../../brave/vendor/bat-native-ledger/src/bat/ledger/internal/media/youtube_unittest.cc:498)
MediaYouTubeTest.GetVideoUrl (../../brave/vendor/bat-native-ledger/src/bat/ledger/internal/media/youtube_unittest.cc:466)
-
browser tests
All tests passed 🎉 -
npm run test-security
Fails because wallet can't be initialized
|
@bsclifton rebased and unit tests are passing |
bsclifton
approved these changes
May 7, 2019
There was a problem hiding this comment.
I still get the above two failures for unit tests - but I also get them with 0.65.x without this PR. Since browser tests and audit pass just fine, let's get this merged
@NejcZdovc will look into the unit test failure
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
add network audit whitelist entries for crlset PR
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
add network audit whitelist entries for crlset PR
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
add network audit whitelist entries for crlset PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift for #2269
Fixes brave/brave-browser#4008