Fix the Ad Rewards settings panel #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
previously requested changes
Apr 18, 2019
| } | ||
|
|
||
| ledger::TransactionsInfo info; | ||
| info.FromJson(transactions); | ||
|
|
There was a problem hiding this comment.
This is the worst change I've ever seen, whitespace is for idiots! - this comment is just a test :)
There was a problem hiding this comment.
sorry sir I will not do this again :-(
tmancey
force-pushed
the
issues/4008
branch
3 times, most recently
from
47dc6ad
to
d6c23f5
Compare
tmancey
force-pushed
the
issues/4008
branch
4 times, most recently
from
2dc905f
to
233f5df
Compare
ryanml
approved these changes
Apr 18, 2019
tmancey
dismissed
bridiver’s stale review
This was a test and we need to merge for uplift so will test in another PR
This was referenced Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes brave/brave-browser#4008
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Confirm that "Ad notifications received" and "Estimated earnings this cycle" on the Rewards Panel include the current cycle and past transactions which were not redeemed, i.e. missed the deadline.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.