Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WhatsApp Web not working on nightly (works on 0.66.x) #4608

Closed
agentofuser opened this issue May 25, 2019 · 11 comments · Fixed by brave/brave-core#2583
Closed

WhatsApp Web not working on nightly (works on 0.66.x) #4608

agentofuser opened this issue May 25, 2019 · 11 comments · Fixed by brave/brave-core#2583
Assignees
@bsclifton
Labels
QA/No release-notes/exclude webcompat/not-shields-related Sites are breaking because of something other than Shields.
Milestone
0.67.x - Release

Comments

@agentofuser
Copy link

agentofuser commented May 25, 2019 •
edited
Loading

Description

WhatsApp Web tell me to "update Chrome" when I try to open it on Nightly.

Steps to Reproduce

  1. https://web.whatsapp.com

Actual result:

image

Expected result:

Opens WhatsApp Web.

Reproduces how often:

Every time.

Brave version (brave://version info)

0.67.55 Chromium: 75.0.3770.38 (Official Build) nightly (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X
JavaScript V8 7.5.288.16
Flash (Disabled)
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.38 Safari/537.36

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Not sure.
  • Can you reproduce this issue with the beta channel?
    Not sure.
  • Can you reproduce this issue with the dev channel?
    No. It works on Dev.
  • Can you reproduce this issue with the nightly channel?
    Yes.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No.
  • Does the issue resolve itself when disabling Brave Rewards?
    No.
  • Is the issue reproducible on the latest version of Chrome?
    No.
@agentofuser agentofuser changed the title WhatsApp Web not working on nightly (works on WhatsApp Web not working on nightly (works on dev) May 25, 2019
@bsclifton bsclifton added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label May 26, 2019
@bsclifton
Copy link
Member

Possibly related to our recent UA change
cc: @bbondy @simonhong

@srirambv
Copy link
Contributor

srirambv commented May 27, 2019 •
edited
Loading

Confirmed due to the new Brave UA. Even adding a full major/minor version to Brave doesn't fix the issue. Only way is to remove Brave UA
image

Update: Seems to work when you restart browser with Brave UA. The first attempt fails but subsequent restart works fine.
image

@srirambv srirambv added the needs-investigation A bug not 100% confirmed/fixed label May 27, 2019
@bsclifton bsclifton mentioned this issue May 28, 2019
Merged
28 tasks
@kjozwiak
Copy link
Member

+1 to get this fixed. Heavy WhatsApp desktop user.

@bsclifton bsclifton mentioned this issue May 29, 2019
Closed
@Sberla996
Copy link

+1 really need Whatsapp web to work!

@kjozwiak
Copy link
Member

kjozwiak commented Jun 2, 2019

+1 from https://twitter.com/torgo/status/1135085452317331456

@kjozwiak
Copy link
Member

kjozwiak commented Jun 2, 2019 •
edited
Loading

Went through the following using macOS 10.14.5 x64:

  • 0.68.6 Chromium: 75.0.3770.38 (nightly) - Issue is reproducible
  • 0.67.72 Chromium: 75.0.3770.38 (dev) - Issue is reproducible
  • 0.66.80 Chromium: 75.0.3770.38 (beta) - Not reproducible
  • 0.65.116 Chromium: 75.0.3770.38 (release RC) - Not reproducible

Looks like 0.68.x (nightly) & 0.67.x (dev) are affected. Definitely looks like the UA changes are causing the issue as nightly and dev are both using the following UA:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.38 Safari/537.36 Brave/75

Both 0.66.x (beta) and 0.65.x (release) are currently using the following UA:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.38 Safari/537.36

@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2019

@rebron this issue is getting more attention, we should get this fixed sooner than later.

@bsclifton
Copy link
Member

@kjozwiak this is tied to the UA. We have an issue proposing a fix here (which is what you want to thumbs up / prioritize):
#4641

@bsclifton bsclifton removed the needs-investigation A bug not 100% confirmed/fixed label Jun 3, 2019
@bsclifton bsclifton mentioned this issue Jun 3, 2019
Merged
29 tasks
@bsclifton bsclifton self-assigned this Jun 3, 2019
mihaiplesa pushed a commit to brave/brave-core that referenced this issue Jun 4, 2019
@bsclifton @mihaiplesa
Revert changes to user agent after experiencing webcompat issues in D…
2a4a7ff 
…ev/Nightly.

Proposed solution:
1. revert this code :) leave the header code in (for the time being) to ensure partner compatibility
2. create a new branch and make the UA toggle-able (ex: "Use Brave user agent") in brave://settings (default to off)
3. continue to flush out UA exceptions as part of brave/brave-browser#4641
4. re-submit work as pull request

Fixes brave/brave-browser#4608
Unfixes brave/brave-browser#1052
(we can remove milestone from brave/brave-browser#4623 as revert won't break this)

-----

Revert "Merge pull request #2515 from brave/fix_ua"
This reverts commit 1a135b6, reversing
changes made to 0160133.

Revert "Merge pull request #2442 from brave/override_ua"
This reverts commit f5a2264, reversing
changes made to 7f958f8.
bsclifton added a commit to brave/brave-core that referenced this issue Jun 4, 2019
@bsclifton
Revert changes to user agent after experiencing webcompat issues in D…
1d4ca9e 
…ev/Nightly.

Proposed solution:
1. revert this code :) leave the header code in (for the time being) to ensure partner compatibility
2. create a new branch and make the UA toggle-able (ex: "Use Brave user agent") in brave://settings (default to off)
3. continue to flush out UA exceptions as part of brave/brave-browser#4641
4. re-submit work as pull request

Fixes brave/brave-browser#4608
Unfixes brave/brave-browser#1052
(we can remove milestone from brave/brave-browser#4623 as revert won't break this)

-----

Revert "Merge pull request #2515 from brave/fix_ua"
This reverts commit 1a135b6, reversing
changes made to 0160133.

Revert "Merge pull request #2442 from brave/override_ua"
This reverts commit f5a2264, reversing
changes made to 7f958f8.
@bsclifton bsclifton mentioned this issue Jun 4, 2019
Merged
4 tasks
@bsclifton bsclifton added this to the 0.68.x - Nightly milestone Jun 4, 2019
@bsclifton bsclifton changed the title WhatsApp Web not working on nightly (works on dev) WhatsApp Web not working on nightly (works on 0.66.x) Jun 4, 2019
@bsclifton
Copy link
Member

Marked as QA/No since this feature was introduced and then reverted

@GeetaSarvadnya
Copy link

+1 from https://community.brave.com/t/whatsapp-web-doesnt-work-on-latest-brave/62444/10

@vitorHoller
Copy link

vitorHoller commented Nov 3, 2020 •
edited
Loading

Another Whatsapp issue;
Translation: Whatsapp works with Google Chrome 49+
To use Whatsapp, update Chrome or use Mozilla FIrefox, Safari, Microsoft Edge or Opera
Update Google Chrome

wpp issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
QA/No release-notes/exclude webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Milestone
0.67.x - Release
Development

Successfully merging a pull request may close this issue.

Revert changes to user agent after experiencing webcompat issues in Dev/Nightly brave/brave-core
7 participants
@kjozwiak @bsclifton @srirambv @GeetaSarvadnya @Sberla996 @agentofuser @vitorHoller