Revert changes to user agent after experiencing webcompat issues in Dev/Nightly #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working through a compile error related to Random usage in referral service... |
|
Done and pushed 👍 Ready for review 😄 |
bsclifton
commented
Jun 3, 2019
| base::TimeDelta::FromSeconds(kFetchReferralHeadersFrequency + | ||
| base::RandInt(0, 60 * 10)), | ||
| base::TimeDelta::FromSeconds( | ||
| brave_base::random::Geometric(kFetchReferralHeadersFrequency)), |
There was a problem hiding this comment.
cc: @riastradh-brave - updated per discussion on Slack
bsclifton
force-pushed
the
bsc-user-agent-update
branch
from
5318760 to
fac599c
Compare
bsclifton
force-pushed
the
bsc-user-agent-update
branch
from
fac599c to
f0bae56
Compare
…ev/Nightly. Proposed solution: 1. revert this code :) leave the header code in (for the time being) to ensure partner compatibility 2. create a new branch and make the UA toggle-able (ex: "Use Brave user agent") in brave://settings (default to off) 3. continue to flush out UA exceptions as part of brave/brave-browser#4641 4. re-submit work as pull request Fixes brave/brave-browser#4608 Unfixes brave/brave-browser#1052 (we can remove milestone from brave/brave-browser#4623 as revert won't break this) ----- Revert "Merge pull request #2515 from brave/fix_ua" This reverts commit 1a135b6, reversing changes made to 0160133. Revert "Merge pull request #2442 from brave/override_ua" This reverts commit f5a2264, reversing changes made to 7f958f8.
mihaiplesa
force-pushed
the
bsc-user-agent-update
branch
from
8dcb54f to
42f559e
Compare
This was referenced Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert changes to user agent after experiencing webcompat issues in Dev/Nightly
Proposed solution:
Fixes brave/brave-browser#4608
Unfixes brave/brave-browser#1052
(we can remove milestone from brave/brave-browser#4623 as revert won't break this)
Revert "Merge pull request #2515 from brave/fix_ua"
This reverts commit 1a135b6, reversing
changes made to 0160133.
Revert "Merge pull request #2442 from brave/override_ua"
This reverts commit f5a2264, reversing
changes made to 7f958f8.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.