Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave://version doesn't show our custom UA properly #4623

Closed
simonhong opened this issue May 28, 2019 · 2 comments · Fixed by brave/brave-core#2515
Closed

brave://version doesn't show our custom UA properly #4623

simonhong opened this issue May 28, 2019 · 2 comments · Fixed by brave/brave-core#2515
Assignees
@simonhong
Labels
QA/No release-notes/exclude
Milestone
0.67.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented May 28, 2019 •
edited
Loading

As brave/brave-core#2442 merged, brave://version also should display custom UA.
Note: navigator.userAgent api displays our custom UA properly.

Steps to reproduce:

  1. Launch browser and load brave://version
  2. Check ua contains brave/xx
@simonhong simonhong self-assigned this May 28, 2019
@simonhong simonhong mentioned this issue May 28, 2019
Merged
28 tasks
@simonhong simonhong added this to the 0.67.x - Nightly milestone May 28, 2019
@simonhong simonhong mentioned this issue May 28, 2019
Merged
28 tasks
@bsclifton
Copy link
Member

Marking as QA/No and release-notes/exclude as test plan was updated in brave/brave-core#2442

General functionality covered by #1052 which is labelled appropriately

@bsclifton bsclifton mentioned this issue Jun 3, 2019
Merged
29 tasks
mihaiplesa pushed a commit to brave/brave-core that referenced this issue Jun 4, 2019
@bsclifton @mihaiplesa
Revert changes to user agent after experiencing webcompat issues in D…
2a4a7ff 
…ev/Nightly.

Proposed solution:
1. revert this code :) leave the header code in (for the time being) to ensure partner compatibility
2. create a new branch and make the UA toggle-able (ex: "Use Brave user agent") in brave://settings (default to off)
3. continue to flush out UA exceptions as part of brave/brave-browser#4641
4. re-submit work as pull request

Fixes brave/brave-browser#4608
Unfixes brave/brave-browser#1052
(we can remove milestone from brave/brave-browser#4623 as revert won't break this)

-----

Revert "Merge pull request #2515 from brave/fix_ua"
This reverts commit 1a135b6, reversing
changes made to 0160133.

Revert "Merge pull request #2442 from brave/override_ua"
This reverts commit f5a2264, reversing
changes made to 7f958f8.
bsclifton added a commit to brave/brave-core that referenced this issue Jun 4, 2019
@bsclifton
Revert changes to user agent after experiencing webcompat issues in D…
1d4ca9e 
…ev/Nightly.

Proposed solution:
1. revert this code :) leave the header code in (for the time being) to ensure partner compatibility
2. create a new branch and make the UA toggle-able (ex: "Use Brave user agent") in brave://settings (default to off)
3. continue to flush out UA exceptions as part of brave/brave-browser#4641
4. re-submit work as pull request

Fixes brave/brave-browser#4608
Unfixes brave/brave-browser#1052
(we can remove milestone from brave/brave-browser#4623 as revert won't break this)

-----

Revert "Merge pull request #2515 from brave/fix_ua"
This reverts commit 1a135b6, reversing
changes made to 0160133.

Revert "Merge pull request #2442 from brave/override_ua"
This reverts commit f5a2264, reversing
changes made to 7f958f8.
@bsclifton bsclifton removed this from the 0.67.x - Dev milestone Jun 4, 2019
@bsclifton
Copy link
Member

Milestone removed after this was reverted. Test plan was already updated in brave/brave-core#2442 and revert squashed both commits together

@bbondy bbondy added this to the 0.67.x - Release milestone Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
QA/No release-notes/exclude
Projects
None yet
Milestone
0.67.x - Release
Development

Successfully merging a pull request may close this issue.

Make brave://version display UA properly brave/brave-core
3 participants
@bbondy @bsclifton @simonhong