Skip to content

Commit

Permalink
Revert the disabling of WebSQL after finding extension breakage
Browse files Browse the repository at this point in the history
Speed dial extension was affected; may impact others too.

Fixes brave/brave-browser#8542

-----

Revert "Merge pull request #4463 from brave/disable_websql"

This reverts commit a50fa1d, reversing
changes made to cd4edd3.
  • Loading branch information
bsclifton committed Mar 5, 2020
1 parent 0985439 commit c56ed77
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 52 deletions.
2 changes: 0 additions & 2 deletions app/brave_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,6 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
command_line.AppendSwitchASCII(switches::kSyncServiceURL,
"https://no-thanks.invalid");

command_line.AppendSwitch(switches::kDisableDatabases);

// Enabled features.
const std::unordered_set<const char*> enabled_features = {
// Upgrade all mixed content
Expand Down
6 changes: 0 additions & 6 deletions app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "components/password_manager/core/common/password_manager_features.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/common/content_features.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/web_preferences.h"
#include "gpu/config/gpu_finch_features.h"
#include "services/network/public/cpp/features.h"
Expand All @@ -40,11 +39,6 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisableHyperlinkAuditing) {
EXPECT_FALSE(prefs.hyperlink_auditing_enabled);
}

IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisableWebSQL) {
EXPECT_TRUE(base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisableDatabases));
}

IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
const base::Feature* disabled_features[] = {
&autofill::features::kAutofillServerCommunication,
Expand Down
43 changes: 0 additions & 43 deletions app/websql_browsertest.cc

This file was deleted.

1 change: 0 additions & 1 deletion test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,6 @@ test("brave_browser_tests") {
testonly = true
sources = [
"//brave/app/brave_main_delegate_browsertest.cc",
"//brave/app/websql_browsertest.cc",
"//brave/browser/autocomplete/brave_autocomplete_provider_client_browsertest.cc",
"//brave/browser/brave_scheme_load_browsertest.cc",
"//brave/browser/autoplay/autoplay_permission_context_browsertest.cc",
Expand Down

0 comments on commit c56ed77

Please sign in to comment.