Fix 7522: Disable WebSQL #4463
Merged
Fix 7522: Disable WebSQL #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumde
force-pushed
the
disable_websql
branch
3 times, most recently
from
fb79f49
to
a9cff6d
Compare
|
haven't tried it but the approach and test plan lgtm |
simonhong
reviewed
Jan 31, 2020
app/websql_browsertest.cc
Outdated
| void SetUpOnMainThread() override { | ||
| InProcessBrowserTest::SetUpOnMainThread(); | ||
|
|
||
| content_client_.reset(new ChromeContentClient); |
There was a problem hiding this comment.
I think we don't need explicitly set again content client and browser content client here.
They also will be set properly for browser test.
simonhong
reviewed
Jan 31, 2020
app/websql_browsertest.cc
Outdated
| ASSERT_TRUE(content::WaitForLoadStop(contents)); | ||
| EXPECT_EQ(url, contents->GetURL()); | ||
|
|
||
| bool websqlBlocked; |
There was a problem hiding this comment.
nit: websql_blocked is our convention.
jumde
force-pushed
the
disable_websql
branch
2 times, most recently
from
eaf2135
to
fe6e9f8
Compare
jumde
force-pushed
the
disable_websql
branch
2 times, most recently
from
e1e7cdf
to
b652be8
Compare
bsclifton
added a commit
that referenced
this pull request
Mar 5, 2020
Speed dial extension was affected; may impact others too. Fixes brave/brave-browser#8542 ----- Revert "Merge pull request #4463 from brave/disable_websql" This reverts commit a50fa1d, reversing changes made to cd4edd3.
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#7522
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.