Foreground/Background notifications aren't implemented on Linux for Brave Ads #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
commented
Jan 29, 2019
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "bat_ads", | |||
| "display_name": "Bat Ads Service", | |||
| "sandbox_type": "utility", | |||
| "sandbox_type": "none", | |||
There was a problem hiding this comment.
the process continually restarted on linux with the sandbox enabled. ledger service process also has sandbox disabled
bridiver
commented
Jan 29, 2019
| @@ -1,5 +1,5 @@ | |||
| import("//build/config/features.gni") | |||
|
|
|||
| declare_args() { | |||
| brave_ads_enabled = !is_linux | |||
| brave_ads_enabled = !is_android | |||
There was a problem hiding this comment.
tmancey
previously approved these changes
Feb 27, 2019
|
@bridiver can you update to have a more descriptive PR title? Might help if we're looking for a regression range, etc |
tmancey
force-pushed
the
issues/2511
branch
2 times, most recently
from
cada34c
to
dfc2a5e
Compare
tmancey
previously approved these changes
Feb 27, 2019
tmancey
changed the title
tmancey
force-pushed
the
issues/2511
branch
3 times, most recently
from
9a4ab77
to
9f0e6af
Compare
tmancey
force-pushed
the
issues/2511
branch
3 times, most recently
from
9282cb9
to
7106621
Compare
tmancey
previously approved these changes
Apr 8, 2019
tmancey
previously approved these changes
Apr 8, 2019
tmancey
approved these changes
Apr 8, 2019
This was referenced Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes brave/brave-browser#2511
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Confirm AdsService Event Log is logged to console for "foreground" and "background" events. Launch browser from command-line with following arguments:
--enable-logging=stderr --vmodule=brave_ads=3.Reviewer Checklist: