Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreground/Background notifications aren't implemented on Linux for Brave Ads 0.63.x #2184

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Foreground/Background notifications aren't implemented on Linux for Brave Ads 0.63.x #2184

merged 1 commit into from
Apr 9, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 9, 2019

Uplift for #1482
Fixes brave/brave-browser#2511

@tmancey tmancey added this to the 0.63.x - Beta milestone Apr 9, 2019
@tmancey tmancey self-assigned this Apr 9, 2019
@tmancey tmancey requested a review from a team April 9, 2019 10:49
rebron
rebron approved these changes Apr 9, 2019
View reviewed changes
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Reviewed with @kjozwiak and @bbondy.

@tmancey tmancey merged commit 9fd329a into 0.63.x Apr 9, 2019
@tmancey tmancey deleted the issues/2511-0.63.x branch April 9, 2019 16:50
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@mihaiplesa
Merge pull request #2184 from brave/fix-apt-install-docs
d17f51e 
removed append from tee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebron rebron rebron approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
0.63.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@tmancey @rebron @bridiver