Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NoScript interface #2485

Merged
merged 4 commits into from
Jun 6, 2019
Merged

Update NoScript interface #2485

merged 4 commits into from
Jun 6, 2019

Commits on Jun 5, 2019

  1. change logic of noScript interactions 

    -
blocking a script now takes effect immeditately.
scripts blocked now go to the blocked list only after second interaction
address brave/brave-browser#2996
    @cezaraugusto @bsclifton
    cezaraugusto authored and bsclifton committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    30358e3 View commit details
    Browse the repository at this point in the history

  2. add new noScript interface 

    -
* scripts now show intermediary state "allowed once" and "blocked once"
* lists with zero items are now hidden
* add ability to see grouped scripts

fix brave/brave-browser#4572
fix brave/brave-browser#4570
fix brave/brave-browser#4567
address brave/brave-browser#2996
    @cezaraugusto @bsclifton
    cezaraugusto authored and bsclifton committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    86d5b33 View commit details
    Browse the repository at this point in the history

  3. fix scripts number being different across screens 

    -
scripts now use the same method for checking scripts blocked
fix brave/brave-browser#4228
    @cezaraugusto @bsclifton
    cezaraugusto authored and bsclifton committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    6272cd3 View commit details
    Browse the repository at this point in the history

  4. add tests for all new functions

    @cezaraugusto @bsclifton
    cezaraugusto authored and bsclifton committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    8a5a061 View commit details
    Browse the repository at this point in the history