Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 6633: Prevent click event from bubbling up to the toggle #4042

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Nov 20, 2019

Fix brave/brave-browser#6633

Submitter Checklist:

Test Plan:

  1. Navigate to brave://settings/privacy
  2. Open a new tab for https://www.brave.com
  3. Toggle Push Messaging setting
  4. Click relaunch
  5. Verify that Push Messaging is enabled after restart
  6. Navigate to https://gauntface.github.io/simple-push-demo/ and verify push messaging works

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde self-assigned this Nov 20, 2019
@jumde jumde force-pushed the push_messaging_relaunch_fix branch from 9754055 to 293ba62 Compare November 20, 2019 20:14
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully 😄👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Relaunch' button re-toggles 'Push Messaging' feature before relaunching
2 participants