Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Remove placeholder in buy amount field. Use USD as default buy currency #7709

Closed
nuo-xu opened this issue Jul 10, 2023 · 1 comment · Fixed by #7879
Closed

Remove placeholder in buy amount field. Use USD as default buy currency #7709

nuo-xu opened this issue Jul 10, 2023 · 1 comment · Fixed by #7879
Assignees
@StephenHeaps
Labels
enhancement Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.58

Comments

@nuo-xu
Copy link
Contributor

nuo-xu commented Jul 10, 2023 •
edited by StephenHeaps
Loading

  1. Remove placeholder in buy amount field.
  2. Use USD as default buy currency
@nuo-xu nuo-xu added this to Web3 Jul 10, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jul 14, 2023
@StephenHeaps StephenHeaps changed the title Wallet: Remove Apple Pay copy in buy option. Remove placeholder in buy amount field. Use USD as default buy currency Remove placeholder in buy amount field. Use USD as default buy currency Aug 15, 2023
@StephenHeaps StephenHeaps self-assigned this Aug 15, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Aug 15, 2023
@StephenHeaps StephenHeaps added this to the 1.57 milestone Aug 15, 2023
@StephenHeaps StephenHeaps mentioned this issue Aug 15, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps modified the milestones: 1.57, 1.58 Aug 17, 2023
@iccub iccub removed this from the 1.58 milestone Sep 18, 2023
@StephenHeaps StephenHeaps added this to the 1.58 milestone Sep 19, 2023
StephenHeaps added a commit that referenced this issue Sep 19, 2023
@StephenHeaps
Fix #7794, #7709: Add Stripe on ramp, buy token tweaks (#7879)
77eb1d8 
* Add support for Stripe OnRamp (US-only)

* Add unit test for `supportedProviders` after moving into `BuyTokenStore` from the view.

* Select USD by default, remove currency code from placeholder

* Use region identifier / code instead of language code to restrict to US.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Sep 19, 2023
StephenHeaps added a commit that referenced this issue Sep 19, 2023
@StephenHeaps
Fix #7794, #7709: Add Stripe on ramp, buy token tweaks (#7879)
52069f3 
* Add support for Stripe OnRamp (US-only)

* Add unit test for `supportedProviders` after moving into `BuyTokenStore` from the view.

* Select USD by default, remove currency code from placeholder

* Use region identifier / code instead of language code to restrict to US.
@srirambv
Copy link
Contributor

Verified as part of #7794 (comment)

@Uni-verse Uni-verse mentioned this issue Nov 27, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7794, brave/brave-ios#7709: Add Stripe on ramp, b…
2a74f96 
…uy token tweaks (brave/brave-ios#7879)

* Add support for Stripe OnRamp (US-only)

* Add unit test for `supportedProviders` after moving into `BuyTokenStore` from the view.

* Select USD by default, remove currency code from placeholder

* Use region identifier / code instead of language code to restrict to US.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
enhancement Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58
Development

Successfully merging a pull request may close this issue.

Fix #7794, #7709: Add Stripe on ramp, buy token tweaks brave/brave-ios
4 participants
@nuo-xu @StephenHeaps @iccub @srirambv