Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Stripe on-ramp #7794

Closed
StephenHeaps opened this issue Jul 27, 2023 · 1 comment · Fixed by #7879
Closed

Stripe on-ramp #7794

StephenHeaps opened this issue Jul 27, 2023 · 1 comment · Fixed by #7879
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.58

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Jul 27, 2023 •
edited
Loading

Description:

Support on-ramp from Stripe in Buy flows.

iOS version of brave/brave-browser#31397
@StephenHeaps StephenHeaps self-assigned this Jul 27, 2023
@HEagle18 HEagle18 moved this to Backlog in Web3 Jul 28, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Aug 10, 2023
@StephenHeaps StephenHeaps added this to the 1.57 milestone Aug 15, 2023
@StephenHeaps StephenHeaps mentioned this issue Aug 15, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps moved this from In Progress to In Review in Web3 Aug 16, 2023
@StephenHeaps StephenHeaps modified the milestones: 1.57, 1.58 Aug 17, 2023
@iccub iccub removed this from the 1.58 milestone Sep 18, 2023
@StephenHeaps StephenHeaps added this to the 1.58 milestone Sep 19, 2023
StephenHeaps added a commit that referenced this issue Sep 19, 2023
@StephenHeaps
Fix #7794, #7709: Add Stripe on ramp, buy token tweaks (#7879)
77eb1d8 
* Add support for Stripe OnRamp (US-only)

* Add unit test for `supportedProviders` after moving into `BuyTokenStore` from the view.

* Select USD by default, remove currency code from placeholder

* Use region identifier / code instead of language code to restrict to US.
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Sep 19, 2023
StephenHeaps added a commit that referenced this issue Sep 19, 2023
@StephenHeaps
Fix #7794, #7709: Add Stripe on ramp, buy token tweaks (#7879)
52069f3 
* Add support for Stripe OnRamp (US-only)

* Add unit test for `supportedProviders` after moving into `BuyTokenStore` from the view.

* Select USD by default, remove currency code from placeholder

* Use region identifier / code instead of language code to restrict to US.
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 17 running 1.58 (23.9.20.15)

  • Verified steps from #7879
  • Verified 0 is shown as the placeholder and USD $ as the default currency selector
  • Verified Stripe On-Ramp is only available when USD is set as the purchase token
  • Verified changing from USD to other Fiat currency doesn't list Stripe as an on-ramp provider
7794.MP4

@srirambv srirambv mentioned this issue Sep 21, 2023
Closed
@Uni-verse Uni-verse mentioned this issue Nov 27, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7794, brave/brave-ios#7709: Add Stripe on ramp, b…
2a74f96 
…uy token tweaks (brave/brave-ios#7879)

* Add support for Stripe OnRamp (US-only)

* Add unit test for `supportedProviders` after moving into `BuyTokenStore` from the view.

* Select USD by default, remove currency code from placeholder

* Use region identifier / code instead of language code to restrict to US.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58
Development

Successfully merging a pull request may close this issue.

Fix #7794, #7709: Add Stripe on ramp, buy token tweaks brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv