Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7794, #7709: Add Stripe on ramp, buy token tweaks #7879

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Fix #7794, #7709: Add Stripe on ramp, buy token tweaks #7879

merged 8 commits into from
Sep 19, 2023

Conversation

StephenHeaps
Copy link
Contributor

@StephenHeaps StephenHeaps commented Aug 15, 2023 •
edited
Loading

Summary of Changes

  • Adds support for Link by Stripe on ramp in buy token view. Stripe is only supported in the US.
  • Selects USD currency as default for Buy
  • Remove placeholder showing currency symbol to match desktop

This pull request fixes #7794, fixes #7709

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Note: Stripe is only supported in the US. If outside of the US, you've have to update device settings to United States region.

  1. Open Buy Crypto View
  2. Verify 0 displayed as placeholder, $ / USD selected as default currency.
  3. Enter an amount in the buy field (optional) and tap Select purchase method.
  4. Verify Stripe is shown for supported tokens. ETH (ethereum mainnet), MATIC (polygon), SOL (solana mainnet), USDC (ethereum mainnet) tokens are supported by Stripe.
  5. Tap Buy with Link.
  6. Verify wallet dismisses and opens the Stripe purchase page

Screenshots:

stripe.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps self-assigned this Aug 15, 2023
@StephenHeaps StephenHeaps requested a review from a team as a code owner August 15, 2023 20:25
@StephenHeaps StephenHeaps added this to the 1.57 milestone Aug 16, 2023
@StephenHeaps StephenHeaps added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Aug 16, 2023
@StephenHeaps StephenHeaps modified the milestones: 1.57, 1.58 Aug 17, 2023
@StephenHeaps StephenHeaps force-pushed the wallet/stripe-onramp branch 2 times, most recently from 3854fd4 to 1f91444 Compare August 21, 2023 15:22
@StephenHeaps StephenHeaps force-pushed the wallet/stripe-onramp branch 2 times, most recently from bb8e40b to 9cda341 Compare August 29, 2023 15:17
@iccub iccub removed this from the 1.58 milestone Sep 18, 2023
@StephenHeaps StephenHeaps added this to the 1.58 milestone Sep 19, 2023
@StephenHeaps StephenHeaps removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Sep 19, 2023
@StephenHeaps StephenHeaps enabled auto-merge (squash) September 19, 2023 15:33
@StephenHeaps StephenHeaps merged commit 77eb1d8 into development Sep 19, 2023
7 checks passed
@StephenHeaps StephenHeaps deleted the wallet/stripe-onramp branch September 19, 2023 15:59
StephenHeaps added a commit that referenced this pull request Sep 19, 2023
@StephenHeaps
Fix #7794, #7709: Add Stripe on ramp, buy token tweaks (#7879)
52069f3 
* Add support for Stripe OnRamp (US-only)

* Add unit test for `supportedProviders` after moving into `BuyTokenStore` from the view.

* Select USD by default, remove currency code from placeholder

* Use region identifier / code instead of language code to restrict to US.
@srirambv srirambv mentioned this pull request Sep 21, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7794, brave/brave-ios#7709: Add Stripe on ramp, b…
2a74f96 
…uy token tweaks (brave/brave-ios#7879)

* Add support for Stripe OnRamp (US-only)

* Add unit test for `supportedProviders` after moving into `BuyTokenStore` from the view.

* Select USD by default, remove currency code from placeholder

* Use region identifier / code instead of language code to restrict to US.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nuo-xu nuo-xu nuo-xu approved these changes

Assignees

@StephenHeaps StephenHeaps

Labels
None yet
Projects
None yet
Milestone
1.58
Development

Successfully merging this pull request may close these issues.

Stripe on-ramp Remove placeholder in buy amount field. Use USD as default buy currency
3 participants
@StephenHeaps @nuo-xu @iccub