Correct relaunch logic

fix #11821, #11824

Auditors: @bsclifton

Test Plan:
a. CHANNEL=beta npm start shouldn't relaunch

b. CHANNEL=beta npm build-package
b-1. ./BraveBeta-win32-x64/BraveBeta.exe should relaunch and use `brave-beta` as user dir
b-2 CHANNEL=beta npm build-installer
b-3 Install Brave by dist/x64/BraveBeta-Setup-x64.exe
b-4 After installation, the first time launch should relaunch and use `brave-beta` as user dir

app/windowsInit.js

@@ -76,13 +76,15 @@ if (process.platform === 'win32') {
   }
 
   const userDataDirSwitch = '--user-data-dir-name=brave-' + channel
-  if (channel && channel !== 'dev' && !process.argv.includes(userDataDirSwitch)) {
+  if (channel !== 'dev' && !process.argv.includes(userDataDirSwitch) &&
+      !process.argv.includes('--relaunch') &&
+      !process.argv.includes('--user-data-dir-name=brave-development')) {
     if (cmd === '--squirrel-firstrun') {
       app.relaunch({args: [userDataDirSwitch, '--relaunch']})
     } else {
-      app.relaunch({args: process.argv.slice(1) + [userDataDirSwitch, '--relaunch']})
+      app.relaunch({args: process.argv.slice(1).concat([userDataDirSwitch, '--relaunch'])})
     }
-    app.quit()
+    app.exit()
   }
 }
 

tools/buildInstaller.js

@@ -178,9 +178,7 @@ if (isDarwin) {
       setupExe: `${appName}-Setup-${arch}.exe`
     })
     resultPromise.then(() => {
-      cmds = [
-      ]
-      execute(cmds, {}, console.log.bind(null, 'done'))
+      console.log('done')
     }, (e) => console.log(`No dice: ${e.message}`))
   })
 } else if (isLinux) {