Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Beta build doesn't launch browser after setup #11821

Closed
srirambv opened this issue Nov 7, 2017 · 0 comments · Fixed by #11838
Closed

Beta build doesn't launch browser after setup #11821

srirambv opened this issue Nov 7, 2017 · 0 comments · Fixed by #11838
Assignees
@bsclifton @darkdh
Labels
0.20.x issue first seen in 0.20.x accessibility bug OS/Windows QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 7, 2017 •
edited by bsclifton
Loading

Test plan

see #11838

Description

Running 0.20.6 setup does nothing, instead of launching the beta browser it just brings Brave to focus

Steps to Reproduce

  1. Clean install 0.20.6
  2. Browser window doesn't launch, instead sets focus to Brave (released version) if open
  3. Double click on the desktop shortcut, launches the beta browser

Actual result:
Beta build doesn't launch browser after setup

Expected result:
Should launch the browser when the setup is complete

Reproduces how often:
Consisitent

Brave Version

about:brave info:

Brave 0.20.6
V8 6.2.414.36
rev 18f7d1e
Muon 4.5.14

Reproducible on current live release:
N/A

Additional Information

#11791
@srirambv srirambv added this to the 0.20.x (Beta Channel) milestone Nov 7, 2017
@bsclifton bsclifton self-assigned this Nov 7, 2017
darkdh added a commit that referenced this issue Nov 8, 2017
@darkdh
Correct relaunch logic
ae4c6c4 
fix #11821, #11824

Auditors: @bsclifton

Test Plan:
a. CHANNEL=beta npm start shouldn't relaunch

b. CHANNEL=beta npm build-package
b-1. ./BraveBeta-win32-x64/BraveBeta.exe should relaunch and use `brave-beta` as user dir
b-2 CHANNEL=beta npm build-installer
b-3 Install Brave by dist/x64/BraveBeta-Setup-x64.exe
b-4 After installation, the first time launch should relaunch and use `brave-beta` as user dir
@darkdh darkdh mentioned this issue Nov 8, 2017
Merged
8 tasks
darkdh added a commit that referenced this issue Nov 10, 2017
@darkdh
Correct relaunch logic
11a45bb 
fix #11821, #11824

Auditors: @bsclifton

Test Plan:
a. CHANNEL=beta npm start shouldn't relaunch

b. CHANNEL=beta npm build-package
b-1. ./BraveBeta-win32-x64/BraveBeta.exe should relaunch and use `brave-beta` as user dir
b-2 CHANNEL=beta npm build-installer
b-3 Install Brave by dist/x64/BraveBeta-Setup-x64.exe
b-4 After installation, the first time launch should relaunch and use `brave-beta` as user dir
darkdh added a commit that referenced this issue Nov 10, 2017
@darkdh
Correct relaunch logic
6e4b725 
fix #11821
fix #11824

Auditors: @bsclifton

Test Plan:
a. CHANNEL=beta npm start shouldn't relaunch

b. CHANNEL=beta npm build-package
b-1. ./BraveBeta-win32-x64/BraveBeta.exe should relaunch and use `brave-beta` as user dir
b-2 CHANNEL=beta npm build-installer
b-3 Install Brave by dist/x64/BraveBeta-Setup-x64.exe
b-4 After installation, the first time launch should relaunch and use `brave-beta` as user dir
@srirambv srirambv mentioned this issue Dec 20, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

@darkdh darkdh

Labels
0.20.x issue first seen in 0.20.x accessibility bug OS/Windows QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Correct relaunch logic brave/browser-laptop
3 participants
@bsclifton @darkdh @srirambv