Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Correct relaunch logic #11838

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Correct relaunch logic #11838

merged 1 commit into from
Nov 10, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Nov 8, 2017 •
edited by bsclifton
Loading

fix #11821, fix #11824

- [ ] blocked by brave/muon#383

Auditors: @bsclifton

Test Plan:

a. CHANNEL=beta npm start shouldn't relaunch

b. CHANNEL=beta npm build-package
b-1. ./BraveBeta-win32-x64/BraveBeta.exe should relaunch and use brave-beta as user dir
b-2 CHANNEL=beta npm build-installer
b-3 Install Brave by dist/x64/BraveBeta-Setup-x64.exe
b-4 After installation, the first time launch should relaunch and use brave-beta as user dir

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@darkdh darkdh added this to the 0.20.x (Beta Channel) milestone Nov 8, 2017
@darkdh darkdh self-assigned this Nov 8, 2017
@darkdh darkdh requested a review from bsclifton November 8, 2017 05:27
@darkdh
Correct relaunch logic
6e4b725 
fix #11821
fix #11824

Auditors: @bsclifton

Test Plan:
a. CHANNEL=beta npm start shouldn't relaunch

b. CHANNEL=beta npm build-package
b-1. ./BraveBeta-win32-x64/BraveBeta.exe should relaunch and use `brave-beta` as user dir
b-2 CHANNEL=beta npm build-installer
b-3 Install Brave by dist/x64/BraveBeta-Setup-x64.exe
b-4 After installation, the first time launch should relaunch and use `brave-beta` as user dir
bsclifton
bsclifton approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the manual testing- everything worked great, as expected 😄 👍 Thanks for taking the time to do this without the Muon change

@bsclifton bsclifton merged commit 2674950 into master Nov 10, 2017
@bsclifton bsclifton deleted the issue-11821 branch November 10, 2017 23:00
bsclifton added a commit that referenced this pull request Nov 10, 2017
@bsclifton
Merge pull request #11838 from brave/issue-11821
85f9142 
Correct relaunch logic
bsclifton added a commit that referenced this pull request Nov 10, 2017
@bsclifton
Merge pull request #11838 from brave/issue-11821
c76d120 
Correct relaunch logic
@bsclifton
Copy link
Member

master 2674950
0.21.x 85f9142
0.20.x c76d120

This was referenced Nov 10, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging this pull request may close these issues.

Beta build doesn't launch from console Beta build doesn't launch browser after setup
2 participants
@darkdh @bsclifton