Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tabs cannot be muted via speaker icon #10544

Closed
luixxiul opened this issue Aug 16, 2017 · 2 comments · Fixed by #10691
Closed

Tabs cannot be muted via speaker icon #10544

luixxiul opened this issue Aug 16, 2017 · 2 comments · Fixed by #10691
Assignees
@cezaraugusto
Labels
bug feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 16, 2017 •
edited
Loading

Test plan

#10691 (comment)

Describe the issue you encountered:
Tabs cannot be muted via speaker icon. That icon does not work.

Brave: 0.20.0
V8: 6.0.286.52
rev: 3e8c8dd
Muon: 4.4.7
OS Release: 16.7.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.3.5
libchromiumcontent: 60.0.3112.90

  • Steps to reproduce:

    1. Open https://www.youtube.com/watch?v=kLiLOkzLetE
    2. Click the speaker icon

  • Actual result: it does not work, while Mute on the tab's context menu works

  • Expected result: it should work

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 17, 2017
@alexwykoff
Copy link
Contributor

@alexwykoff double-check that options work in 0.19

@alexwykoff alexwykoff self-assigned this Aug 22, 2017
@cezaraugusto cezaraugusto self-assigned this Aug 28, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.20.x (Developer Channel), 0.21.x (Nightly Channel) Aug 28, 2017
cezaraugusto added a commit that referenced this issue Aug 28, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
efeb942 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@cezaraugusto cezaraugusto mentioned this issue Aug 28, 2017
Merged
@kjozwiak
Copy link
Member

Only reproducible using 0.20.x. I couldn't reproduce the issue using 0.18.23 and 0.19.3.

The following commit has caused the regression:

commit 33c7dab
Author: Brian Clifton brian@clifton.me
Date: Mon Aug 14 23:21:16 2017 -0700

Merge pull request #9887 from brave/tabsbar--preview-timing

make tab previews based on mouse idle time

Results:

Brave 0.20.0 rev | 33c7dab - 100% Reproducible
Muon 4.4.7
libchromiumcontent 60.0.3112.90

Brave 0.19.3 rev | 053c863 - Couldn't reproduce
Muon 4.4.9
libchromiumcontent 60.0.3112.101

Brave 0.18.23rev | 36ae2ec - Couldn't reproduce
Muon 4.3.10
libchromiumcontent 60.0.3112.90

cezaraugusto added a commit that referenced this issue Aug 29, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
7660913 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@alexwykoff alexwykoff removed their assignment Sep 12, 2017
@ghost ghost added the sprint/1 label Sep 13, 2017
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
UI bug fixing
23fcc08 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7925
fix #10544
fix #10123
fix #10509
fix #10582
fix #10611
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
UI bug fixing
7c58204 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
UI bug fixing
2427327 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
UI bug fixing
94ba1a1 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 19, 2017
@cezaraugusto
UI bug fixing
321281b 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@cezaraugusto @syuan100
UI bug fixing
ac96632 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix brave#6716
fix brave#7301
fix brave#7730
fix brave#7765
fix brave#7925
fix brave#10123
fix brave#10509
fix brave#10544
fix brave#10582
fix brave#10611
fix brave#10838
This was referenced Dec 20, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Dec 27, 2017
Closed
35 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

improve tabs performance and UI with this one simple trick brave/browser-laptop
6 participants
@alexwykoff @kjozwiak @luixxiul @cezaraugusto @srirambv @LaurenWags