Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fading effect b/w tabs feels like flickering #6716

Closed
bobinson opened this issue Jan 18, 2017 · 4 comments · Fixed by #10691
Closed

fading effect b/w tabs feels like flickering #6716

bobinson opened this issue Jan 18, 2017 · 4 comments · Fixed by #10691

Comments

@bobinson
Copy link

bobinson commented Jan 18, 2017

Test plan

#10691 (comment)


Describe the issue you encountered:
This is a minor UX aspect. While moving the mouse pointer from an active tab to a another one, the transition from active tab to inactive background tab is not smooth. Its like a flickering. The screen is re-drawn way too fast.

Expected behavior:

A smooth transition will be great.

  • Platform : macOS 10.12.2, all softwares and development tools updated.

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev d7a324a
    Muon 2.0.11
    libchromiumcontent 54.0.2840.100
    V8 5.4.500.41
    Node.js 7.0.0
    Update Channel dev
    os.platform darwin
    os.release 16.3.0
    os.arch x64

// minor refinement request.

#6665

@aakashysharma
Copy link

aakashysharma commented Feb 13, 2017

Instead of creating a new issue, I'd like to give my feedback here.

The hover/preview effect is maybe nice but at the same time confusing.

  1. If a user hovers over a different tab head, the preview of the other tab is displayed in full size.
  2. This makes user want to click on the preview content he sees.
  3. However, the user would have to click first on the tab head first and then on the content.
  4. However, for a new user like me, I hoped that clicking on the previewed content opens it up.
  5. Since brave's implementation is different, it ends up as accidental clicks on random areas on other page.

The preview being in full size implies that you should be able to click on the previewed tab content to switch focus. The current/longer way doesn't seem to be a good UX design. I think, it can be made better.

@cezaraugusto cezaraugusto added feature/tabsbar polish Nice to have — usually related to front-end/visual tasks. suggestion labels Feb 13, 2017
@lucidNTR
Copy link
Contributor

@bobinson could you clarify? is this flicker maybe just the grey-out overlay animation or do you think it is the actual page-preview, that flickers?

@luixxiul luixxiul added the bug label Jun 4, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jun 4, 2017

@cezaraugusto I feel you fixed the issue recently, don't you?

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Jun 5, 2017

yes but not in master and needs @bradleyrichter approval first. Work is done in brad-preview-bundle branch if anyone is interested. Feedback welcome

@luixxiul luixxiul added this to the 0.18.x milestone Jun 6, 2017
@cezaraugusto cezaraugusto self-assigned this Jun 8, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.19.x, 0.18.x (Frozen, only critical adds from here) Jun 12, 2017
@alexwykoff alexwykoff modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel) Jul 18, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.20.x (Developer Channel), 0.21.x (Nightly Channel) Sep 10, 2017
@ghost ghost added the sprint/1 label Sep 13, 2017
cezaraugusto added a commit that referenced this issue Sep 14, 2017
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7925
fix #10544
fix #10123
fix #10509
fix #10582
fix #10611
cezaraugusto added a commit that referenced this issue Sep 14, 2017
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 19, 2017
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix brave#6716
fix brave#7301
fix brave#7730
fix brave#7765
fix brave#7925
fix brave#10123
fix brave#10509
fix brave#10544
fix brave#10582
fix brave#10611
fix brave#10838
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.