Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Throttling between window resize cause tabContent to pop #7925

Closed
cezaraugusto opened this issue Mar 28, 2017 · 1 comment · Fixed by #10691
Closed

Throttling between window resize cause tabContent to pop #7925

cezaraugusto opened this issue Mar 28, 2017 · 1 comment · Fixed by #10691
Assignees
@cezaraugusto
Labels
bug feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Mar 28, 2017 •
edited by luixxiul
Loading

Test plan

#10691 (comment)

Per @bradleyrichter screenshot:

poppicons_redraw_lag

My guess is that at some point tab size is undefined making icons to pop to the minimum possible (smallest breakpoint), making UI look weird. Should also be related to how we throttle window resize.

Alternatively we can also store last breakpoint state until it finds the next one.
@cezaraugusto cezaraugusto self-assigned this Mar 28, 2017
@bsclifton
Copy link
Member

@cezaraugusto it looks like they're about to explode! 😛

@cezaraugusto cezaraugusto added this to the 0.20.x (Developer Channel) milestone Aug 22, 2017
cezaraugusto added a commit that referenced this issue Aug 28, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
efeb942 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@cezaraugusto cezaraugusto mentioned this issue Aug 28, 2017
Merged
cezaraugusto added a commit that referenced this issue Aug 29, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
7660913 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@ghost ghost added the sprint/1 label Sep 13, 2017
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
UI bug fixing
23fcc08 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7925
fix #10544
fix #10123
fix #10509
fix #10582
fix #10611
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
UI bug fixing
7c58204 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
UI bug fixing
2427327 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
UI bug fixing
94ba1a1 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 19, 2017
@cezaraugusto
UI bug fixing
321281b 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@cezaraugusto @syuan100
UI bug fixing
ac96632 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix brave#6716
fix brave#7301
fix brave#7730
fix brave#7765
fix brave#7925
fix brave#10123
fix brave#10509
fix brave#10544
fix brave#10582
fix brave#10611
fix brave#10838
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

improve tabs performance and UI with this one simple trick brave/browser-laptop
5 participants
@luixxiul @cezaraugusto @bsclifton @srirambv @LaurenWags