Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tabs grow too large or small when closing, until mouseout #11434

Closed
petemill opened this issue Oct 11, 2017 · 0 comments · Fixed by #11436
Closed

Tabs grow too large or small when closing, until mouseout #11434

petemill opened this issue Oct 11, 2017 · 0 comments · Fixed by #11436

Comments

@petemill
Copy link
Member

petemill commented Oct 11, 2017

Test plan

#11436 (comment)


Description

When using the mouse to close tabs via the close button [x], all the tabs often grow larger than the tab should be, not only making the next tab's close button not under the mouse cursor, but making all the tabs either too large or too small compared to how they will end up when the mouse is moved away from the tabs

Steps to Reproduce

  1. Make the window narrow
  2. Open ~7 tabs (enough for the tabs to fill the width of the container and get smaller
  3. Mouse over the first tab's close button and click it

Actual result:
The next tab grows bigger (or smaller if you opened many many tabs)

Expected result:

The next tab stays exactly the same size, until mouseout of the tab bar

Brave Version

master - 74688c9 (0.21.0)
macOS

Reproducible on current live release:
No, neither on 0.19.37

@petemill petemill self-assigned this Oct 11, 2017
@luixxiul luixxiul added the bug label Oct 11, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 11, 2017
Fix brave#11434

The tabs are meant to stay the same size until mouseout, according to brave#6088 and implemented in brave#6342. They were sometimes growing (or shrinking) on click and then shrinking further on mouseout due to the size being calculated at the wrong time
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Oct 13, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Fix brave#11434

The tabs are meant to stay the same size until mouseout, according to brave#6088 and implemented in brave#6342. They were sometimes growing (or shrinking) on click and then shrinking further on mouseout due to the size being calculated at the wrong time
@luixxiul luixxiul modified the milestones: 0.22.x (Nightly Channel), 0.20.x (Beta Channel) Jan 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.