Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Keep tabs same size when closing #6088

Closed
luixxiul opened this issue Dec 8, 2016 · 2 comments
Closed

Keep tabs same size when closing #6088

luixxiul opened this issue Dec 8, 2016 · 2 comments
Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.2

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 8, 2016

https://community.brave.com/t/keep-tabs-same-size-when-closing/74?u=suguru

When I have a lot of tabs open in Chrome and go to close them, the tabs stay the same size. That way I can click and close a lot of tabs one after the other without moving my mouse. But in Brave, the tabs resize to fit the window, which means, I have to move my mouse to close another tab.
@bbondy
Copy link
Member

bbondy commented Dec 11, 2016

This bothers me too, thanks for posting.

@NejcZdovc NejcZdovc mentioned this issue Jan 19, 2017
Closed
@gyandeeps gyandeeps mentioned this issue Jan 19, 2017
Merged
4 tasks
bsclifton added a commit that referenced this issue Jan 23, 2017
@bsclifton
Merge pull request #6342 from gyandeeps/issue6088
b733ab9 
Update: Keep tabs same size when closing (fixes #6088)
@bsclifton bsclifton added this to the 0.13.1 milestone Jan 23, 2017
@bsclifton
Copy link
Member

bsclifton commented Jan 23, 2017 •
edited
Loading

Fixed with #6342

Test Plan

  1. open 7-8 tabs (doesn't matter what the content is; can be empty)
  2. move your cursor to the close button of the second tab from left
  3. Now as you keep clicking it will maintain the size of the tabs
  4. The size will reset as soon as you move your cursor outside the tab area.

bsclifton pushed a commit that referenced this issue Jan 24, 2017
@gyandeeps @bsclifton
Update: Keep tabs same size when closing (fixes #6088)
9ef6d6d 
Same behavior as chrome
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@gyandeeps @bsclifton
Update: Keep tabs same size when closing (fixes #6088)
53529f0 
Same behavior as chrome
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@gyandeeps @bsclifton
Update: Keep tabs same size when closing (fixes #6088)
b53a9c2 
Same behavior as chrome
bsclifton pushed a commit that referenced this issue Jan 26, 2017
@gyandeeps @bsclifton
Update: Keep tabs same size when closing (fixes #6088)
ddeb75c 
Same behavior as chrome
bbondy added a commit that referenced this issue Jan 28, 2017
@bbondy
Fix active tab not showing when tab size stays the same
6fde912 
This fixes all the failing tab page tests

Related to #6088
bbondy added a commit that referenced this issue Jan 28, 2017
@bbondy
Rename tab close by mouse action to be more explicit
4a907a8 
The old name wouldn't be invoked for all types of tab closes, so it was a misleading name for future
people that write code. They might have used that event thinking they'd get all tab closes.

Auditors: @bsclifton

Related to #6088
@luixxiul luixxiul mentioned this issue Feb 2, 2017
Closed
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 11, 2017
@petemill
Fix bug affecting width of tabs when closing them with the mouse.
7a87334 
Fix brave#11434

The tabs are meant to stay the same size until mouseout, according to brave#6088 and implemented in brave#6342. They were sometimes growing (or shrinking) on click and then shrinking further on mouseout due to the size being calculated at the wrong time
@petemill petemill mentioned this issue Oct 11, 2017
Merged
8 tasks
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@petemill @syuan100
Fix bug affecting width of tabs when closing them with the mouse.
6f5f857 
Fix brave#11434

The tabs are meant to stay the same size until mouseout, according to brave#6088 and implemented in brave#6342. They were sometimes growing (or shrinking) on click and then shrinking further on mouseout due to the size being calculated at the wrong time
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
5 participants
@aekeus @bbondy @luixxiul @bsclifton @srirambv