This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Fix bug affecting width of tabs when closing them with the mouse #11436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix brave#11434 The tabs are meant to stay the same size until mouseout, according to brave#6088 and implemented in brave#6342. They were sometimes growing (or shrinking) on click and then shrinking further on mouseout due to the size being calculated at the wrong time
Codecov Report
@@ Coverage Diff @@
## master #11436 +/- ##
==========================================
- Coverage 52.46% 52.44% -0.02%
==========================================
Files 268 268
Lines 25195 25182 -13
Branches 4021 4020 -1
==========================================
- Hits 13218 13207 -11
+ Misses 11977 11975 -2
|
8 tasks
cezaraugusto
approved these changes
Oct 13, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+++++ works flawlessly, thanks!
Added to 0.22.x. |
This PR also fixes #12837 which is assigned to 0.20, so changing milestone for this to 0.20 and uplifting to 0.21 and 0.20 |
petemill
pushed a commit
that referenced
this pull request
Jan 25, 2018
Fix bug affecting width of tabs when closing them with the mouse
petemill
pushed a commit
that referenced
this pull request
Jan 25, 2018
Fix bug affecting width of tabs when closing them with the mouse
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11434
The tabs are meant to stay the same size until mouseout, according to #6088 and implemented in #6342. They were sometimes growing (or shrinking) on click and then shrinking further on mouseout due to the size being calculated at the wrong time.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan (manual):
flex tabs
max-width tabs
Reviewer Checklist:
Tests