Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Open file doesn't open default download location #13229

Closed
srirambv opened this issue Feb 21, 2018 · 7 comments · Fixed by brave/muon#508
Closed

Open file doesn't open default download location #13229

srirambv opened this issue Feb 21, 2018 · 7 comments · Fixed by brave/muon#508
Labels
0.22.x issue first seen in 0.22.x addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. muon OS/Windows priority/P4 Minor loss of function. Workaround usually present. QA/test-plan-specified release-notes/exclude wontfix

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 21, 2018 •
edited by bsclifton
Loading

Test plan

  1. Launch Brave and open Menu->File->Open File...
  2. Default download location should properly show (ex: c:\Users\clifton\Downloads)

Description

Open file doesn't open default download location

Steps to Reproduce

  1. Menu->File->Open File...
  2. The default path shown is Desktop

Actual result:
11906-openfile

Expected result:
Should show default download location when file open option is selected

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.21.10
V8 6.4.388.41
rev fd80122
Muon 5.0.2
OS Release 10.0.16299
Update Channel  
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.140

Reproducible on current live release:
N/A

Additional Information

Found while testing #11906
@srirambv srirambv added muon 0.21.x issue first seen in 0.21.x labels Feb 21, 2018
@srirambv srirambv added this to the 0.21.x (Beta Channel) milestone Feb 21, 2018
@darkdh
Copy link
Member

darkdh commented Feb 21, 2018

seems like Windows only and it will use last location you used to open file no matter fresh profile or not

@btlechowski
Copy link
Contributor

Opening last used location is the intended behavior. Chrome and Firefox behave the same.

Nevertheless, when clean install is done then it should open default download location.

@kjozwiak @LaurenWags Your thoughts?

@darkdh
Copy link
Member

darkdh commented Feb 23, 2018

Just tested Chrome and Firefox by fresh profile on Windows
Both initial location will be the application install location not default download location

@darkdh
Copy link
Member

darkdh commented Feb 23, 2018

nvm, I think I have the fix for initial location

darkdh added a commit to brave/muon that referenced this issue Feb 23, 2018
@darkdh
Using DIR_DEFAULT_DOWNLOADS_SAFE when DIR_DEFAULT_DOWNLOADS got home
588042a 
directory or desktop

fix brave/browser-laptop#13229
fix brave/browser-laptop#13255

Auditors: @bridiver, @bsclifton
@darkdh darkdh mentioned this issue Feb 23, 2018
Merged
darkdh added a commit to brave/muon that referenced this issue Feb 23, 2018
@darkdh
Using DIR_DEFAULT_DOWNLOADS_SAFE when DIR_DEFAULT_DOWNLOADS got home
1e62668 
directory or desktop

fix brave/browser-laptop#13229
fix brave/browser-laptop#13255

Auditors: @bridiver, @bsclifton
@bsclifton bsclifton added 0.22.x issue first seen in 0.22.x and removed 0.21.x issue first seen in 0.21.x labels Feb 27, 2018
@alexwykoff alexwykoff modified the milestones: 0.22.x (Developer Channel), Backlog (Prioritized) Feb 27, 2018
@alexwykoff alexwykoff added the priority/P4 Minor loss of function. Workaround usually present. label Feb 27, 2018
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.22.xx, 0.22.x (Developer Channel) Feb 27, 2018
@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.21.x w/ Chromium 65 (Beta Channel) Mar 1, 2018
@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Beta Channel), 0.22.x (Developer Channel) Mar 9, 2018
@btlechowski
Copy link
Contributor

The issue is still reproducible for Open File(CTRL + O).

Reproduced on Windows 7 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Cannot reproduce when saving a file(CTRL+S).

@btlechowski btlechowski reopened this Mar 27, 2018
@darkdh darkdh modified the milestones: 0.22.x (Beta Channel), 0.23.x (Developer Channel) Mar 27, 2018
@alexwykoff alexwykoff modified the milestones: 0.23.x (Developer Channel), Backlog (Prioritized) Apr 3, 2018
@bsclifton bsclifton added wontfix addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. labels Sep 7, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 7, 2018
@bsclifton
Copy link
Member

This should be addressed in our Developer channel release; if not, we can track it there. I can't confirm because I'm not seeing a way to open files... but the dialog does come up (and save the path) when saving pictures, etc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
0.22.x issue first seen in 0.22.x addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. muon OS/Windows priority/P4 Minor loss of function. Workaround usually present. QA/test-plan-specified release-notes/exclude wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using DIR_DEFAULT_DOWNLOADS_SAFE brave/muon
7 participants
@petemill @alexwykoff @jumde @bsclifton @darkdh @srirambv @btlechowski