This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Using DIR_DEFAULT_DOWNLOADS_SAFE
#508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directory or desktop fix brave/browser-laptop#13229 fix brave/browser-laptop#13255 Auditors: @bridiver, @bsclifton
darkdh
force-pushed
the
browser-laptop-issue-13229
branch
from
588042a
to
1e62668
Compare
bsclifton
approved these changes
Mar 1, 2018
bsclifton
added a commit
that referenced
this pull request
Mar 1, 2018
Using `DIR_DEFAULT_DOWNLOADS_SAFE`
bsclifton
added a commit
that referenced
this pull request
Mar 1, 2018
Using `DIR_DEFAULT_DOWNLOADS_SAFE`
bsclifton
added a commit
that referenced
this pull request
Mar 1, 2018
Using `DIR_DEFAULT_DOWNLOADS_SAFE`
bridiver
reviewed
Mar 1, 2018
| @@ -86,6 +87,23 @@ struct Converter<file_dialog::DialogSettings> { | |||
|
|
|||
| namespace { | |||
|
|
|||
| // Consider downloads 'dangerous' if they go to the home directory on Linux and | |||
| // to the desktop on any platform. | |||
| bool DownloadPathIsDangerous(const base::FilePath& download_path) { | |||
There was a problem hiding this comment.
cc @jumde - this will conflict with your PR I think and the safe_browsing changes should take priority
There was a problem hiding this comment.
in your branch please update this to use download_prefs.cc version of DownloadPathIsDangerous
There was a problem hiding this comment.
or remove the whole change if this is no longer necessary
There was a problem hiding this comment.
jumde
added a commit
that referenced
this pull request
Mar 8, 2018
darkdh
added a commit
that referenced
this pull request
Jun 20, 2018
miscommunication in #508 (review) fix brave/browser-laptop#14407 Auditors: @bridiver, @jumde
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when DIR_DEFAULT_DOWNLOADS got home directory or desktop
fix brave/browser-laptop#13229
fix brave/browser-laptop#13255
Auditors: @bridiver, @bsclifton