Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

unable to export bookmarks #13255

Closed
LaurenWags opened this issue Feb 22, 2018 · 3 comments · Fixed by #13266 or brave/muon#508
Closed

unable to export bookmarks #13255

LaurenWags opened this issue Feb 22, 2018 · 3 comments · Fixed by #13266 or brave/muon#508
Assignees
@darkdh
Labels
0.22.x issue first seen in 0.22.x bug feature/bookmarks feature/exporter priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@LaurenWags
Copy link
Member

Description

Bookmarks don't export. See test case D from #11906

Steps to Reproduce

  1. Set up some bookmarks on a clean profile (I had 2 on my toolbar and 2 in a folder on the toolbar)
  2. Menu->Bookmarks->Export bookmarks
  3. The default path should be your download path
  4. The dialog should have extension option with html
  5. Default extension is html
  6. Click Save on the dialog.

Actual result:
Bookmark export file is not created.

Expected result:
Bookmark export file should be created.

Reproduces how often:
Easily. Confirmed by @btlechowski on Linux and @srirambv on Windows.

Brave Version

about:brave info:
Brave | 0.21.11
V8 | 6.4.388.41
rev | e146cd8
Muon | 5.0.5
OS Release | 16.7.0
Update Channel | Beta
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 64.0.3282.140

Reproducible on current live release:
no

Additional Information

cc @darkdh
@LaurenWags LaurenWags added this to the 0.21.x (Beta Channel) milestone Feb 22, 2018
@darkdh darkdh self-assigned this Feb 22, 2018
darkdh added a commit that referenced this issue Feb 23, 2018
@darkdh
Fix the filename exporter written to
5beb288 
fix #13255

Auditors: @bsclifton

Test Plan:
1. Set up some bookmarks on a clean profile
2. Menu->Bookmarks->Export bookmarks
3. The default path should be your download path
4. The dialog should have extension option with html
5. Default extension is html
6. Click Save on the dialog.
@darkdh darkdh mentioned this issue Feb 23, 2018
Merged
10 tasks
@srirambv
Copy link
Collaborator

srirambv commented Feb 23, 2018 •
edited
Loading

Default path in save file window isn't download path. But bookmark exports successfully

@srirambv srirambv reopened this Feb 23, 2018
darkdh added a commit to brave/muon that referenced this issue Feb 23, 2018
@darkdh
Using DIR_DEFAULT_DOWNLOADS_SAFE when DIR_DEFAULT_DOWNLOADS got home
588042a 
directory or desktop

fix brave/browser-laptop#13229
fix brave/browser-laptop#13255

Auditors: @bridiver, @bsclifton
@darkdh darkdh mentioned this issue Feb 23, 2018
Merged
darkdh added a commit to brave/muon that referenced this issue Feb 23, 2018
@darkdh
Using DIR_DEFAULT_DOWNLOADS_SAFE when DIR_DEFAULT_DOWNLOADS got home
1e62668 
directory or desktop

fix brave/browser-laptop#13229
fix brave/browser-laptop#13255

Auditors: @bridiver, @bsclifton
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@darkdh @ryanml
Fix the filename exporter written to
4209f86 
fix brave#13255

Auditors: @bsclifton

Test Plan:
1. Set up some bookmarks on a clean profile
2. Menu->Bookmarks->Export bookmarks
3. The default path should be your download path
4. The dialog should have extension option with html
5. Default extension is html
6. Click Save on the dialog.
@bsclifton bsclifton added 0.22.x issue first seen in 0.22.x and removed 0.21.x issue first seen in 0.21.x labels Feb 27, 2018
@alexwykoff alexwykoff added the priority/P3 Major loss of function. label Feb 27, 2018
@alexwykoff alexwykoff modified the milestones: 0.22.x (Developer Channel), Backlog (Prioritized) Feb 27, 2018
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.22.x (Developer Channel) Feb 27, 2018
@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.21.x w/ Chromium 65 (Beta Channel) Mar 1, 2018
@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Beta Channel), 0.22.x (Developer Channel) Mar 9, 2018
@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
0.22.x issue first seen in 0.22.x bug feature/bookmarks feature/exporter priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
8 participants
@petemill @alexwykoff @kjozwiak @bsclifton @darkdh @srirambv @LaurenWags @btlechowski