Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Scrollbar is sometimes stuck in scrolling #13580

Closed
btlechowski opened this issue Mar 23, 2018 · 12 comments · Fixed by brave/muon#545
Closed

Scrollbar is sometimes stuck in scrolling #13580

btlechowski opened this issue Mar 23, 2018 · 12 comments · Fixed by brave/muon#545
Assignees
@darkdh
Labels
0.21.x issue first seen in 0.21.x bug fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. priority/P3 Major loss of function. QA/test-plan-specified regression release-notes/include wontfix

Comments

@btlechowski
Copy link
Contributor

Steps to Reproduce

  1. Open: about:welcome
  2. Move mouse pointer over scrollbar and hold it with Left Mouse Button
  3. While holding Left Mouse Button move the pointer over URL field
  4. Release Left Mouse Button

Actual result:
scroll broken

Expected result:
Scrollbar is not stuck in scrolling

Reproduces how often:
100%

Brave Version

Brave: 0.22.7 
V8: 6.5.254.41 
rev: 8bb7e77f69bca186429aafda4bc6ba4d82a5de47 
Muon: 5.1.1 
OS Release: 6.1.7601 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.181

@LaurenWags reported that it is reproducible on v0.21.24, but not on v0.21.18

Additional Information

Also reproduced when moving mouse pointer outside of Brave window.
Below reproduced for scrollbar arrow:
scroll arrow broken

cc @LaurenWags @srirambv @kjozwiak @bsclifton
@btlechowski btlechowski added this to the 0.22.x (Beta Channel) milestone Mar 23, 2018
@LaurenWags
Copy link
Member

many +1s from community:
https://community.brave.com/t/cant-stop-vertical-scrolling/18194
https://community.brave.com/t/scroll-bar-wont-stop-scrolling/18135

@petemill petemill added the 0.21.x issue first seen in 0.21.x label Mar 23, 2018
darkdh added a commit to brave/muon that referenced this issue Mar 23, 2018
@darkdh
Handle mouse up/down in async
4808118 
fix brave/browser-laptop#13580

@Auditors: @bridiver, @bbondy
@darkdh darkdh mentioned this issue Mar 23, 2018
Merged
darkdh added a commit to brave/muon that referenced this issue Mar 23, 2018
@darkdh
Handle mouse up/down in async
1ab3e2c 
fix brave/browser-laptop#13580

Auditors: @bridiver, @bbondy
@darkdh darkdh self-assigned this Mar 23, 2018
darkdh added a commit to brave/muon that referenced this issue Mar 23, 2018
@darkdh
Handle mouse up/down in async
554772b 
fix brave/browser-laptop#13580

Auditors: @bridiver, @bsclifton
@jayyyin
Copy link

jayyyin commented Mar 24, 2018

has this issue been fixed?

@kjozwiak
Copy link
Member

has this issue been fixed?

Looks like @darkdh has been working on a fix via brave/muon@554772b. The PR is on the muon side of things. Once the new muon version with the above fix is merged into 0.22.x, this will be closed and then verified by QA.

@btlechowski
Copy link
Contributor Author

btlechowski commented Mar 28, 2018 •
edited by kjozwiak
Loading

Verified on Windows 7 x64

  • 0.22.8 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.11 56de947
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Mint 18.3 x64 using the following build:

  • 0.22.11 56de947
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
This was referenced Apr 3, 2018
Closed
Closed
@btlechowski
Copy link
Contributor Author

The issue still reproduces for a thin line of pixels close to window frame.

  1. Open: about:welcome
  2. Move mouse pointer over center of the scrollbar and hold it with Left Mouse Button
  3. While holding Left Mouse Button move the pointer close to window frame on the right
  4. Release Left Mouse Button

Actual result:
scrollbar_window_frame

Also reproducible for scrollbar arrows

Brave info

Brave: 0.22.13 
V8: 6.5.254.41 
rev: a8cfb160479f1d00d0769368eb440030182bb83b 
Muon: 5.1.2 
OS Release: 6.1.7601 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.181

@btlechowski btlechowski reopened this Apr 3, 2018
@btlechowski btlechowski modified the milestones: 0.22.x (Release Channel), 0.23.x (Developer Channel) Apr 3, 2018
@bsclifton
Copy link
Member

removed OS labels since this affects all platforms

@darkdh
Copy link
Member

darkdh commented May 14, 2018

window frame on the right issue seems like Win 7 only. I can't reproduce it on Win 10 and other platforms

darkdh added a commit to brave/muon that referenced this issue May 14, 2018
@darkdh
Remove render_widget_targeter hack since chromium 66.0.3359.170
9061d71 
This revert

bf26683
554772b
ebac9c9

which solve
brave/browser-laptop#13368
brave/browser-laptop#13480
brave/browser-laptop#13481
brave/browser-laptop#13580

Auditor: @bridiver
@darkdh darkdh mentioned this issue May 14, 2018
Closed
@kjozwiak
Copy link
Member

@LaurenWags @srirambv can you guys take a look and see if you can reproduce the issue? I believe a few of our users also mentioned this was reproducible on Win/macOS but I might be wrong. I'll also try giving this a go on my Win 10 x64 desktop.

@LaurenWags
Copy link
Member

LaurenWags commented May 15, 2018 •
edited
Loading

I can't say it's this particular scrolling issue (@btlechowski logged several scenarios for scrolling problems) but there are multiple reports of scrolling issues on Win 10 in community. Some of which are mentioned here #13580 (comment) - some using a trackpad, some using a mouse.

@srirambv
Copy link
Collaborator

I can't reproduce the issue from #13580 (comment) on Windows 10. When using touch pad to scroll on Windows, there is a different issue where the scroll jumps when mouse pointer is out of focus, but thats a Windows issue that happens on all active application with scroll bar.

@alexwykoff alexwykoff added needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. priority/P3 Major loss of function. labels May 15, 2018
@alexwykoff alexwykoff modified the milestones: 0.23.x (Developer Channel), 0.24.x (Nightly Channel) May 22, 2018
@LaurenWags
Copy link
Member

Multiple +1s from community:
https://community.brave.com/t/scroll-bar-wont-stop-scrolling/18135
https://community.brave.com/t/cant-stop-vertical-scrolling/18194

@alexwykoff alexwykoff added the fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. label Jun 5, 2018
@alexwykoff alexwykoff removed this from the 0.24.x (Nightly Channel) milestone Jun 5, 2018
@kjozwiak kjozwiak removed the fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. label Jun 5, 2018
@bsclifton
Copy link
Member

This issue was closed as wontfix since Brave Core does not have this issue and we'll be moving over to that soon (from our current Muon based product). More information about Brave Core available here:
https://brave.com/development-plans-for-upcoming-release/

@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
0.21.x issue first seen in 0.21.x bug fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. priority/P3 Major loss of function. QA/test-plan-specified regression release-notes/include wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle mouse up/down in async brave/muon
9 participants
@petemill @alexwykoff @kjozwiak @bsclifton @jayyyin @darkdh @srirambv @LaurenWags @btlechowski