This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Remove render_widget_targeter hack since chromium 66.0.3359.170 #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hferreiro @ltilve I'm going to close this, but can you look at removing this patch in C69 and check against the relevant issues? |
|
@hferreiro @ltilve actually you don't need to try removing the patch. We thought with single webview introduced, we can remove this patch hack but turns out we still need it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revert
bf26683
554772b
ebac9c9
which solve
brave/browser-laptop#13368
brave/browser-laptop#13480
brave/browser-laptop#13481
brave/browser-laptop#13580
Auditor: @bridiver