Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Sort ledger table based on % #13721

Closed
NejcZdovc opened this issue Apr 4, 2018 · 6 comments · Fixed by #13726 or #14110
Closed

Sort ledger table based on % #13721

NejcZdovc opened this issue Apr 4, 2018 · 6 comments · Fixed by #13726 or #14110
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.22.x Release 3 ...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 4, 2018 •
edited by LaurenWags
Loading

Test Plan

#13726

Description

Ledger table should be sorted based on % in desc order.
@NejcZdovc NejcZdovc self-assigned this Apr 4, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 4, 2018
@NejcZdovc
Fixes sortTable default sort
2f8036b 
Resolves brave#13721

Auditors:

Test Plan:
This was referenced Apr 4, 2018
Merged
Closed
Closed
@NejcZdovc NejcZdovc modified the milestones: 0.22.x Release 2, 0.22.x Release 3 (Beta channel) Apr 10, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 17, 2018
@NejcZdovc
Fixes sortTable default sort
ba0e4b4 
Resolves brave#13721

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 18, 2018
@NejcZdovc
Fixes sortTable default sort
13a46eb 
Resolves brave#13721

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 18, 2018
@NejcZdovc
Fixes sortTable default sort
d039a44 
Resolves brave#13721

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 19, 2018
@NejcZdovc
Fixes sortTable default sort
2109adb 
Resolves brave#13721

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 19, 2018
@NejcZdovc
Fixes sortTable default sort
772f79a 
Resolves brave#13721

Auditors:

Test Plan:
@NejcZdovc NejcZdovc changed the title Sort ledger table basedf on % Sort ledger table based on % Apr 19, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 19, 2018
@NejcZdovc
Fixes sortTable default sort
5d16f7d 
Resolves brave#13721

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.22.x Release 3 (Beta channel) milestone Apr 19, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 19, 2018
@NejcZdovc
Fixes sortTable default sort
7868702 
Resolves brave#13721

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Apr 19, 2018
@NejcZdovc
Merge pull request #13726 from NejcZdovc/fix/#13721-sort
12d502f 
Fixes sortTable default sort
NejcZdovc added a commit that referenced this issue Apr 19, 2018
@NejcZdovc
Merge pull request #13726 from NejcZdovc/fix/#13721-sort
2cb1beb 
Fixes sortTable default sort
NejcZdovc added a commit that referenced this issue Apr 19, 2018
@NejcZdovc
Merge pull request #13726 from NejcZdovc/fix/#13721-sort
43770d0 
Fixes sortTable default sort
@srirambv srirambv mentioned this issue May 3, 2018
Closed
@srirambv srirambv mentioned this issue May 8, 2018
Closed
@NejcZdovc NejcZdovc reopened this May 13, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 13, 2018
@NejcZdovc
Revert "Merge pull request brave#13726 from NejcZdovc/fix/brave#13721-…
70aa1b9 
…sort"

This reverts commit 12d502f, reversing
changes made to 0abdd64.
NejcZdovc added a commit that referenced this issue May 13, 2018
@NejcZdovc
Merge pull request #14106 from NejcZdovc/revert/13726
f0df761 
Revert "Merge pull request #13726 from NejcZdovc/fix/#13721-sort"
NejcZdovc added a commit that referenced this issue May 13, 2018
@NejcZdovc
Merge pull request #14106 from NejcZdovc/revert/13726
353ba0f 
Revert "Merge pull request #13726 from NejcZdovc/fix/#13721-sort"
NejcZdovc added a commit that referenced this issue May 13, 2018
@NejcZdovc
Merge pull request #14106 from NejcZdovc/revert/13726
57d2008 
Revert "Merge pull request #13726 from NejcZdovc/fix/#13721-sort"
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 13, 2018
@NejcZdovc
Fixes sortTable default sort
64ea8cd 
Resolves brave#13721

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue May 13, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 13, 2018
@NejcZdovc
Fixes sortTable default sort
f34e416 
Resolves brave#13721

Auditors:

Test Plan:
@kjozwiak kjozwiak mentioned this issue May 13, 2018
Closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 14, 2018
@NejcZdovc
Fixes sortTable default sort
a7bdaac 
Resolves brave#13721

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue May 14, 2018
@bsclifton
Merge pull request #14110 from NejcZdovc/fix/#13721-sort2
60ae539 
Fixes sortTable default sort
bsclifton added a commit that referenced this issue May 14, 2018
@bsclifton
Merge pull request #14110 from NejcZdovc/fix/#13721-sort2
3b5bfea 
Fixes sortTable default sort
bsclifton added a commit that referenced this issue May 14, 2018
@bsclifton
Merge pull request #14110 from NejcZdovc/fix/#13721-sort2
15d9231 
Fixes sortTable default sort
This was referenced May 15, 2018
Closed
Closed
Closed
@kjozwiak
Copy link
Member

@srirambv @LaurenWags @GeetaSarvadnya @btlechowski please make sure we also go through the new ledger case [1] that was added into the manual test plan that involves generating 500 entries into the ledger table using npm run add-simulated-synopsis-visits 500.

[1] https://github.com/brave/qa-resources/blob/master/wikitemplate.md#ledger

@LaurenWags
Copy link
Member

LaurenWags commented May 15, 2018 •
edited by kjozwiak
Loading

Verified with macOS 10.12.6 using

  • 0.22.712 e48c5ff
  • muon 6.0.9
  • libchromiumcontent 66.0.3359.139
  • tried 100, 500, 1000 visits

Verified on Windows x64 using

  • 0.22.712 e48c5ff
  • muon 6.0.9
  • libchromiumcontent 66.0.3359.139

Verified on Mint 18.3 x64 using the following build:

  • 0.22.714 fa2fbca
  • Muon: 6.0.9
  • libchromiumcontent: 66.0.3359.139

@kjozwiak kjozwiak mentioned this issue May 16, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
6 participants
@kjozwiak @bsclifton @NejcZdovc @srirambv @LaurenWags @btlechowski