This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13726 +/- ##
==========================================
- Coverage 56.56% 56.44% -0.12%
==========================================
Files 283 283
Lines 28886 28951 +65
Branches 4787 4800 +13
==========================================
+ Hits 16338 16342 +4
- Misses 12548 12609 +61
|
@jasonrsadler nice find. I think that I need to re-think this one. Because if I add specific default sort row then refresh table is not triggered correctly anymore from |
Let me know if I can help |
NejcZdovc
force-pushed
the
fix/#13721-sort
branch
5 times, most recently
from
April 19, 2018 07:05
2109adb
to
772f79a
Compare
NejcZdovc
force-pushed
the
fix/#13721-sort
branch
from
April 19, 2018 07:46
772f79a
to
5d16f7d
Compare
ryanml
previously approved these changes
Apr 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well and looks good to me!
Resolves brave#13721 Auditors: Test Plan:
NejcZdovc
force-pushed
the
fix/#13721-sort
branch
from
April 19, 2018 10:13
5d16f7d
to
7868702
Compare
jasonrsadler
approved these changes
Apr 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works. The table is updated in realtime now
NejcZdovc
added a commit
that referenced
this pull request
Apr 19, 2018
Fixes sortTable default sort
NejcZdovc
added a commit
that referenced
this pull request
Apr 19, 2018
Fixes sortTable default sort
this PR was reverted in #14106 |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13721
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
npm run add-simulated-synopsis-visits 20
Reviewer Checklist:
Tests