Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autofill suggestion should close when field is out of focus #3816

Closed
srirambv opened this issue Sep 8, 2016 · 1 comment · Fixed by #5287
Closed

Autofill suggestion should close when field is out of focus #3816

srirambv opened this issue Sep 8, 2016 · 1 comment · Fixed by #5287
Assignees
@darkdh
Labels
feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.9dev

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 8, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Autofill suggestion should dismiss when field is out of focus. If field is out of view it still shows on the screen in the same position where the suggestion popped up

Expected behavior:
Should close suggestion when the field is not in focus

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.0 (Clean Install)
  • Steps to reproduce:
    1. Create autofill entries
    2. Open the autofill form and click on the field for suggestion to popup
    3. Scroll down the page the suggestion window remains fixed on screen until a mouse click.
  • Screenshot if needed:
    auto
  • Any related issues:

cc: @darkdh
@bsclifton bsclifton mentioned this issue Oct 29, 2016
Closed
@bsclifton
Copy link
Member

related: #4540

@darkdh darkdh self-assigned this Oct 31, 2016
@darkdh darkdh modified the milestones: 1.0.0, 0.12.9dev Oct 31, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 31, 2016
@darkdh
Implement hide-autofill-popup
68d8db6 
fix brave#3816
fix brave#4540
fix brave#5023

Auditors: @bbondy

Test Plan:
1. Go to https://github.com/brave/browser-laptop/issues
2. In the filters textbox, start typing characters until autocomplete pops up
3. Push enter to submit
4. Scroll the page should dismiss the popup

1. Go to https://github.com/brave/browser-laptop/issues
2. In the filters textbox, start typing characters until autocomplete pops up
3. Push enter to submit
4. Popup should be dismissed
@darkdh darkdh mentioned this issue Oct 31, 2016
Merged
4 tasks
This was referenced Nov 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.9dev
Development

Successfully merging a pull request may close this issue.

Implement hide-autofill-popup darkdh/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv